gulpfile.hygiene.js 5.8 KB
Newer Older
J
Joao Moreno 已提交
1 2 3 4 5 6 7 8 9
/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/

var gulp = require('gulp');
var filter = require('gulp-filter');
var es = require('event-stream');
var path = require('path');
J
Joao Moreno 已提交
10
var tslint = require('gulp-tslint');
11
var _tslint = require('tslint');
J
Joao Moreno 已提交
12

13
var all = [
14
	'*',
J
Joao Moreno 已提交
15 16 17 18
	'build/**/*',
	'extensions/**/*',
	'scripts/**/*',
	'src/**/*',
19 20 21 22 23
	'test/**/*'
];

var eolFilter = [
	'**',
24 25
	'!ThirdPartyNotices.txt',
	'!LICENSE.txt',
J
Joao Moreno 已提交
26 27 28
	'!extensions/**/out/**',
	'!**/node_modules/**',
	'!**/fixtures/**',
29
	'!**/*.{svg,exe,png,scpt,bat,cmd,cur,ttf,woff,eot}',
J
Joao Moreno 已提交
30 31 32 33
];

var indentationFilter = [
	'**',
34 35
	'!ThirdPartyNotices.txt',
	'!**/*.md',
36
	'!**/*.template',
37
	'!**/*.yml',
A
Alex Dima 已提交
38
	'!**/lib/**',
J
Joao Moreno 已提交
39 40 41 42
	'!**/*.d.ts',
	'!extensions/typescript/server/**',
	'!test/assert.js',
	'!**/package.json',
A
Alex Dima 已提交
43
	'!**/npm-shrinkwrap.json',
J
Joao Moreno 已提交
44 45 46 47
	'!**/octicons/**',
	'!**/vs/languages/sass/test/common/example.scss',
	'!**/vs/languages/less/common/parser/less.grammar.txt',
	'!**/vs/languages/css/common/buildscripts/css-schema.xml',
J
Johannes Rieken 已提交
48
	'!**/vs/base/common/marked/raw.marked.js',
J
Joao Moreno 已提交
49 50 51 52 53 54 55 56 57 58 59 60
	'!**/vs/base/common/winjs.base.raw.js',
	'!**/vs/base/node/terminateProcess.sh',
	'!**/vs/base/node/terminateProcess.sh',
	'!**/vs/text.js',
	'!**/vs/nls.js',
	'!**/vs/css.js',
	'!**/vs/loader.js',
	'!extensions/**/snippets/**',
	'!extensions/**/syntaxes/**',
	'!extensions/**/themes/**',
];

J
Joao Moreno 已提交
61
var copyrightFilter = [
J
Joao Moreno 已提交
62
	'**',
63
	'!**/*.desktop',
J
Joao Moreno 已提交
64 65
	'!**/*.json',
	'!**/*.html',
66
	'!**/*.template',
J
Joao Moreno 已提交
67 68
	'!**/test/**',
	'!**/*.md',
69 70
	'!**/*.bat',
	'!**/*.cmd',
B
Benjamin Pasero 已提交
71
	'!resources/win32/bin/code.js',
J
Joao Moreno 已提交
72 73 74 75 76
	'!**/*.sh',
	'!**/*.txt',
	'!src/vs/editor/standalone-languages/swift.ts',
];

J
Joao Moreno 已提交
77 78 79 80 81 82 83 84 85
var tslintFilter = [
	'src/**/*.ts',
	'extensions/**/*.ts',
	'!**/*.d.ts',
	'!**/typings/**',
	'!**/*.test.ts',
	'!src/vs/editor/standalone-languages/test/**'
];

J
Joao Moreno 已提交
86 87 88 89 90 91 92
var copyrightHeader = [
	'/*---------------------------------------------------------------------------------------------',
	' *  Copyright (c) Microsoft Corporation. All rights reserved.',
	' *  Licensed under the MIT License. See License.txt in the project root for license information.',
	' *--------------------------------------------------------------------------------------------*/'
].join('\n');

J
Joao Moreno 已提交
93 94 95 96 97 98 99 100 101 102 103 104 105 106 107
/**
 * Reports tslint erros in the format:
 * src/helloWorld.c:5:3: warning: implicit declaration of function ‘prinft’
 */
var lintReporter = function (output, file, options) {
	var relativeBase = file.base.substring(file.cwd.length + 1).replace('\\', '/');
	output.forEach(function (e) {
		var message = relativeBase + e.name + ':' + (e.startPosition.line + 1) + ':' + (e.startPosition.character + 1) + ': ' + e.failure;
		console.log('[tslint] ' + message);
	});
};

gulp.task('tslint', function () {
	return gulp.src(all, { base: '.' })
		.pipe(filter(tslintFilter))
108
		.pipe(tslint({ rulesDirectory: 'build/tslintRules' }))
J
Joao Moreno 已提交
109 110 111 112 113 114
		.pipe(tslint.report(lintReporter, {
			summarizeFailureOutput: false,
			emitError: false
		}));
});

115
var hygiene = exports.hygiene = function (some) {
116
    var errorCount = 0;
J
Joao Moreno 已提交
117 118 119

	var eol = es.through(function (file) {
		if (/\r\n?/g.test(file.contents.toString('utf8'))) {
120
			console.error(file.relative + ': Bad EOL found');
J
Joao Moreno 已提交
121 122 123 124 125 126 127 128 129 130
			errorCount++;
		}

		this.emit('data', file);
	});

	var indentation = es.through(function (file) {
		file.contents
			.toString('utf8')
			.split(/\r\n|\r|\n/)
J
Joao Moreno 已提交
131
			.forEach(function (line, i) {
J
Joao Moreno 已提交
132 133
				if (/^\s*$/.test(line)) {
					// empty or whitespace lines are OK
J
Joao Moreno 已提交
134 135 136 137 138
				} else if (/^[\t]*[^\s]/.test(line)) {
					// good indent
				} else if (/^[\t]* \*/.test(line)) {
					// block comment using an extra space
				} else {
139
					console.error(file.relative + '(' + (i + 1) + ',1): Bad whitespace indentation');
J
Joao Moreno 已提交
140 141 142 143 144 145 146 147 148
					errorCount++;
				}
			});

		this.emit('data', file);
	});

	var copyrights = es.through(function (file) {
		if (file.contents.toString('utf8').indexOf(copyrightHeader) !== 0) {
149
			console.error(file.relative + ': Missing or bad copyright statement');
J
Joao Moreno 已提交
150 151
			errorCount++;
		}
J
Joao Moreno 已提交
152

J
Joao Moreno 已提交
153
		this.emit('data', file);
J
Joao Moreno 已提交
154 155
	});

156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173
	var tslint = es.through(function(file) {
        configuration = _tslint.findConfiguration(null, '.');
        var options = {
            formatter: 'json',
            configuration: configuration,
            rulesDirectory: 'build/tslintRules',
        }
        var contents = file.contents.toString('utf8');
        var linter = new _tslint(file.relative, contents, options);
        var result = linter.lint();
        if (result.failureCount > 0) {
            console.error(file.relative + ': ' + result.failureCount + ' Lint warning(s)');
            errorCount += result.failureCount;
        }
        this.emit('data', file);
    });


174
	return gulp.src(some || all, { base: '.' })
J
Joao Moreno 已提交
175
		.pipe(filter(function (f) { return !f.stat.isDirectory(); }))
176
		.pipe(filter(eolFilter))
J
Joao Moreno 已提交
177 178 179
		.pipe(eol)
		.pipe(filter(indentationFilter))
		.pipe(indentation)
J
Joao Moreno 已提交
180
		.pipe(filter(copyrightFilter))
J
Joao Moreno 已提交
181
		.pipe(copyrights)
182 183
		.pipe(filter(tslintFilter))
		.pipe(tslint)
J
Joao Moreno 已提交
184 185
		.pipe(es.through(null, function () {
			if (errorCount > 0) {
J
Joao Moreno 已提交
186
				this.emit('error', 'Hygiene failed with ' + errorCount + ' errors. Check \'build/gulpfile.hygiene.js\'.');
J
Joao Moreno 已提交
187 188 189 190
			} else {
				this.emit('end');
			}
		}));
191 192 193 194
};

gulp.task('hygiene', function () {
	return hygiene();
J
Joao Moreno 已提交
195
});
196 197 198 199 200 201

// this allows us to run this as a git pre-commit hook
if (require.main === module) {
	var cp = require('child_process');
	cp.exec('git diff --cached --name-only', function (err, out) {
		if (err) {
J
Joao Moreno 已提交
202 203
			console.error();
			console.error(err);
204 205 206 207 208 209 210 211
			process.exit(1);
		}

		var some = out
			.split(/\r?\n/)
			.filter(function (l) { return !!l; });

		hygiene(some).on('error', function (err) {
J
Joao Moreno 已提交
212 213
			console.error();
			console.error(err);
214 215 216 217
			process.exit(1);
		});
	});
}