gulpfile.hygiene.js 6.0 KB
Newer Older
J
Joao Moreno 已提交
1 2 3 4 5 6 7 8
/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/

var gulp = require('gulp');
var filter = require('gulp-filter');
var es = require('event-stream');
J
Joao Moreno 已提交
9 10
var gulptslint = require('gulp-tslint');
var tslint = require('tslint');
J
Joao Moreno 已提交
11

12
var all = [
13
	'*',
J
Joao Moreno 已提交
14 15 16 17
	'build/**/*',
	'extensions/**/*',
	'scripts/**/*',
	'src/**/*',
18 19 20 21 22
	'test/**/*'
];

var eolFilter = [
	'**',
23 24
	'!ThirdPartyNotices.txt',
	'!LICENSE.txt',
J
Joao Moreno 已提交
25 26 27
	'!extensions/**/out/**',
	'!**/node_modules/**',
	'!**/fixtures/**',
28
	'!**/*.{svg,exe,png,scpt,bat,cmd,cur,ttf,woff,eot}',
J
Joao Moreno 已提交
29
	'!build/{lib,tslintRules}/**/*.js'
J
Joao Moreno 已提交
30 31 32 33
];

var indentationFilter = [
	'**',
34 35
	'!ThirdPartyNotices.txt',
	'!**/*.md',
36
	'!**/*.template',
37
	'!**/*.yml',
A
Alex Dima 已提交
38
	'!**/lib/**',
J
Joao Moreno 已提交
39 40 41 42
	'!**/*.d.ts',
	'!extensions/typescript/server/**',
	'!test/assert.js',
	'!**/package.json',
A
Alex Dima 已提交
43
	'!**/npm-shrinkwrap.json',
J
Joao Moreno 已提交
44 45 46 47
	'!**/octicons/**',
	'!**/vs/languages/sass/test/common/example.scss',
	'!**/vs/languages/less/common/parser/less.grammar.txt',
	'!**/vs/languages/css/common/buildscripts/css-schema.xml',
J
Johannes Rieken 已提交
48
	'!**/vs/base/common/marked/raw.marked.js',
J
Joao Moreno 已提交
49 50 51 52 53 54 55 56 57
	'!**/vs/base/common/winjs.base.raw.js',
	'!**/vs/base/node/terminateProcess.sh',
	'!**/vs/base/node/terminateProcess.sh',
	'!**/vs/text.js',
	'!**/vs/nls.js',
	'!**/vs/css.js',
	'!**/vs/loader.js',
	'!extensions/**/snippets/**',
	'!extensions/**/syntaxes/**',
J
Joao Moreno 已提交
58
	'!extensions/**/themes/**'
J
Joao Moreno 已提交
59 60
];

J
Joao Moreno 已提交
61
var copyrightFilter = [
J
Joao Moreno 已提交
62
	'**',
63
	'!**/*.desktop',
J
Joao Moreno 已提交
64 65
	'!**/*.json',
	'!**/*.html',
66
	'!**/*.template',
J
Joao Moreno 已提交
67 68
	'!**/test/**',
	'!**/*.md',
69 70
	'!**/*.bat',
	'!**/*.cmd',
B
Benjamin Pasero 已提交
71
	'!resources/win32/bin/code.js',
J
Joao Moreno 已提交
72 73
	'!**/*.sh',
	'!**/*.txt',
D
Daniel Imms 已提交
74
	'!**/*.xpm',
J
Joao Moreno 已提交
75 76 77
	'!src/vs/editor/standalone-languages/swift.ts',
];

J
Joao Moreno 已提交
78 79 80 81 82
var tslintFilter = [
	'src/**/*.ts',
	'extensions/**/*.ts',
	'!**/*.d.ts',
	'!**/typings/**',
A
Alex Dima 已提交
83 84 85 86
	'!src/vs/base/**/*.test.ts',
	'!src/vs/languages/**/*.test.ts',
	'!src/vs/workbench/**/*.test.ts',
	'!extensions/**/*.test.ts',
J
Joao Moreno 已提交
87 88
];

J
Joao Moreno 已提交
89 90 91 92 93 94 95
var copyrightHeader = [
	'/*---------------------------------------------------------------------------------------------',
	' *  Copyright (c) Microsoft Corporation. All rights reserved.',
	' *  Licensed under the MIT License. See License.txt in the project root for license information.',
	' *--------------------------------------------------------------------------------------------*/'
].join('\n');

J
Joao Moreno 已提交
96 97 98 99 100 101 102 103 104 105 106 107 108
function failureReporter(failure) {
	var name = failure.name || failure.fileName;
	var position = failure.startPosition;
	var line = position.lineAndCharacter ? position.lineAndCharacter.line : position.line;
	var character = position.lineAndCharacter ? position.lineAndCharacter.character : position.character;

	console.error(
		name
		+ ':' + (line + 1)
		+ ':' + (character + 1)
		+ ': ' + failure.failure
	);
}
J
Joao Moreno 已提交
109 110

gulp.task('tslint', function () {
J
Joao Moreno 已提交
111 112 113 114 115 116
	var options = { summarizeFailureOutput: true };

	function reporter(failures) {
		failures.forEach(failureReporter);
	}

J
Joao Moreno 已提交
117 118
	return gulp.src(all, { base: '.' })
		.pipe(filter(tslintFilter))
J
Joao Moreno 已提交
119
		.pipe(gulptslint({ rulesDirectory: 'build/lib/tslint' }))
J
Joao Moreno 已提交
120
		.pipe(gulptslint.report(reporter, options));
J
Joao Moreno 已提交
121 122
});

J
Joao Moreno 已提交
123
var hygiene = exports.hygiene = function (some, options) {
J
fix npe  
Joao Moreno 已提交
124
	options = options || {};
J
Joao Moreno 已提交
125
	var errorCount = 0;
J
Joao Moreno 已提交
126 127 128

	var eol = es.through(function (file) {
		if (/\r\n?/g.test(file.contents.toString('utf8'))) {
129
			console.error(file.relative + ': Bad EOL found');
J
Joao Moreno 已提交
130 131 132 133 134 135 136 137 138 139
			errorCount++;
		}

		this.emit('data', file);
	});

	var indentation = es.through(function (file) {
		file.contents
			.toString('utf8')
			.split(/\r\n|\r|\n/)
J
Joao Moreno 已提交
140
			.forEach(function (line, i) {
J
Joao Moreno 已提交
141 142
				if (/^\s*$/.test(line)) {
					// empty or whitespace lines are OK
J
Joao Moreno 已提交
143 144 145 146 147
				} else if (/^[\t]*[^\s]/.test(line)) {
					// good indent
				} else if (/^[\t]* \*/.test(line)) {
					// block comment using an extra space
				} else {
148
					console.error(file.relative + '(' + (i + 1) + ',1): Bad whitespace indentation');
J
Joao Moreno 已提交
149 150 151 152 153 154 155 156 157
					errorCount++;
				}
			});

		this.emit('data', file);
	});

	var copyrights = es.through(function (file) {
		if (file.contents.toString('utf8').indexOf(copyrightHeader) !== 0) {
158
			console.error(file.relative + ': Missing or bad copyright statement');
J
Joao Moreno 已提交
159 160
			errorCount++;
		}
J
Joao Moreno 已提交
161

J
Joao Moreno 已提交
162
		this.emit('data', file);
J
Joao Moreno 已提交
163 164
	});

J
Joao Moreno 已提交
165
	var tsl = es.through(function(file) {
D
Daniel Imms 已提交
166
		var configuration = tslint.findConfiguration(null, '.');
J
Joao Moreno 已提交
167 168 169
		var options = {
			formatter: 'json',
			configuration: configuration,
J
Joao Moreno 已提交
170
			rulesDirectory: 'build/lib/tslint',
J
Joao Moreno 已提交
171 172
		}
		var contents = file.contents.toString('utf8');
J
Joao Moreno 已提交
173
		var linter = new tslint(file.relative, contents, options);
J
Joao Moreno 已提交
174 175
		var result = linter.lint();
		if (result.failureCount > 0) {
J
Joao Moreno 已提交
176
			result.failures.forEach(failureReporter);
J
Joao Moreno 已提交
177 178 179 180
			errorCount += result.failureCount;
		}
		this.emit('data', file);
	});
181

182
	return gulp.src(some || all, { base: '.' })
J
Joao Moreno 已提交
183
		.pipe(filter(function (f) { return !f.stat.isDirectory(); }))
184
		.pipe(filter(eolFilter))
J
Joao Moreno 已提交
185
		.pipe(options.skipEOL ? es.through() : eol)
J
Joao Moreno 已提交
186 187
		.pipe(filter(indentationFilter))
		.pipe(indentation)
J
Joao Moreno 已提交
188
		.pipe(filter(copyrightFilter))
J
Joao Moreno 已提交
189
		.pipe(copyrights)
190
		.pipe(filter(tslintFilter))
J
Joao Moreno 已提交
191
		.pipe(tsl)
J
Joao Moreno 已提交
192 193
		.pipe(es.through(null, function () {
			if (errorCount > 0) {
J
Joao Moreno 已提交
194
				this.emit('error', 'Hygiene failed with ' + errorCount + ' errors. Check \'build/gulpfile.hygiene.js\'.');
J
Joao Moreno 已提交
195 196 197 198
			} else {
				this.emit('end');
			}
		}));
199 200 201 202
};

gulp.task('hygiene', function () {
	return hygiene();
J
Joao Moreno 已提交
203
});
204 205 206 207

// this allows us to run this as a git pre-commit hook
if (require.main === module) {
	var cp = require('child_process');
J
Joao Moreno 已提交
208 209 210
	cp.exec('git config core.autocrlf', function (err, out) {
		var skipEOL = out.trim() === 'true';

211
		cp.exec('git diff --cached --name-only', { maxBuffer: 2000 * 1024 }, function (err, out) {
J
Joao Moreno 已提交
212 213 214 215 216
			if (err) {
				console.error();
				console.error(err);
				process.exit(1);
			}
217

J
Joao Moreno 已提交
218 219 220
			var some = out
				.split(/\r?\n/)
				.filter(function (l) { return !!l; });
221

J
Joao Moreno 已提交
222 223 224 225 226
			hygiene(some, { skipEOL: skipEOL }).on('error', function (err) {
				console.error();
				console.error(err);
				process.exit(1);
			});
227 228 229
		});
	});
}