From fd4039aff488ae84236ee974fa7a327246a2c9ce Mon Sep 17 00:00:00 2001 From: kohsuke Date: Wed, 21 Oct 2009 15:23:08 +0000 Subject: [PATCH] cosmetic changes git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22983 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/model/Queue.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/hudson/model/Queue.java b/core/src/main/java/hudson/model/Queue.java index 09f52ab728..d2ba96cc78 100644 --- a/core/src/main/java/hudson/model/Queue.java +++ b/core/src/main/java/hudson/model/Queue.java @@ -417,12 +417,11 @@ public class Queue extends ResourceController implements Saveable { */ private synchronized WaitingItem scheduleInternal(Task p, int quietPeriod, List actions) { WaitingItem added=null; - List items = getItems(p); - Calendar due = new GregorianCalendar(); + Calendar due = new GregorianCalendar(); due.add(Calendar.SECOND, quietPeriod); List duplicatesInQueue = new ArrayList(); - for(Item item : items) { + for(Item item : getItems(p)) { boolean shouldScheduleItem = false; for (QueueAction action: item.getActions(QueueAction.class)) { shouldScheduleItem |= action.shouldSchedule(actions); @@ -449,7 +448,7 @@ public class Queue extends ResourceController implements Saveable { if ((item instanceof WaitingItem)) waitingDuplicates.add((WaitingItem)item); } - if(duplicatesInQueue.size() == 0) { + if(duplicatesInQueue.isEmpty()) { // all duplicates in the queue are already in the blocked or // buildable stage no need to requeue return null; -- GitLab