From f31ad9c1ebe2bcf7ce03f37b9df7747d25c17253 Mon Sep 17 00:00:00 2001
From: kohsuke <kohsuke@71c3de6d-444a-0410-be80-ed276b4c234a>
Date: Thu, 19 Feb 2009 19:19:37 +0000
Subject: [PATCH]     Build parameter settings are lost when you save the
 configuration. Regression since 1.284.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@15458 71c3de6d-444a-0410-be80-ed276b4c234a
---
 .../java/hudson/model/ParametersDefinitionProperty.java     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/core/src/main/java/hudson/model/ParametersDefinitionProperty.java b/core/src/main/java/hudson/model/ParametersDefinitionProperty.java
index 36c6baef8a..e15033d312 100644
--- a/core/src/main/java/hudson/model/ParametersDefinitionProperty.java
+++ b/core/src/main/java/hudson/model/ParametersDefinitionProperty.java
@@ -151,12 +151,14 @@ public class ParametersDefinitionProperty extends JobProperty<AbstractProject<?,
                 return null;
             }
 
-            if (req.getParameter("parameterized") == null) {
+            JSONObject parameterized = formData.getJSONObject("parameterized");
+
+            if (parameterized.isNullObject()) {
             	return null;
             }
             
             List<ParameterDefinition> parameterDefinitions = Descriptor.newInstancesFromHeteroList(
-                    req, formData, "parameter", ParameterDefinition.LIST);
+                    req, parameterized, "parameter", ParameterDefinition.LIST);
             if(parameterDefinitions.isEmpty())
                 return null;
 
-- 
GitLab