From e19e0ebd7bf1db22ea686ba5de3fa36da5a95f86 Mon Sep 17 00:00:00 2001
From: Kohsuke Kawaguchi <kk@kohsuke.org>
Date: Thu, 31 Mar 2011 17:24:06 -0700
Subject: [PATCH] noting legacy stuff

---
 core/src/main/java/hudson/model/Job.java                 | 1 +
 core/src/main/resources/hudson/model/Job/configure.jelly | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/core/src/main/java/hudson/model/Job.java b/core/src/main/java/hudson/model/Job.java
index 8991cf7c25..5c1a9aa012 100644
--- a/core/src/main/java/hudson/model/Job.java
+++ b/core/src/main/java/hudson/model/Job.java
@@ -139,6 +139,7 @@ public abstract class Job<JobT extends Job<JobT, RunT>, RunT extends Run<JobT, R
     /**
      * List of {@link UserProperty}s configured for this project.
      */
+    // this should have been DescribableList but now it's too late
     protected CopyOnWriteList<JobProperty<? super JobT>> properties = new CopyOnWriteList<JobProperty<? super JobT>>();
 
     protected Job(ItemGroup parent, String name) {
diff --git a/core/src/main/resources/hudson/model/Job/configure.jelly b/core/src/main/resources/hudson/model/Job/configure.jelly
index 5b28d467c0..cdef885d32 100644
--- a/core/src/main/resources/hudson/model/Job/configure.jelly
+++ b/core/src/main/resources/hudson/model/Job/configure.jelly
@@ -52,7 +52,7 @@ THE SOFTWARE.
           </f:optionalBlock>
         </j:if>
 
-        <!-- job property configurations -->
+        <!-- job property configurations. This should have been <f:descriptorList> -->
         <j:set var="instances" value="${it.properties}" />
         <j:forEach var="d" items="${h.getJobPropertyDescriptors(it.getClass())}" varStatus="loop">
           <j:scope>
-- 
GitLab