From ccb3e4cd501b14f617979117ea31fc21f07b972b Mon Sep 17 00:00:00 2001 From: bale836 Date: Sat, 19 Aug 2017 21:28:48 +0800 Subject: [PATCH] [JENKINS-46288] - Fix ProxyConfiguration validation for NTLM authentication (#2984) /** * Constructor. * @param userName The user name. This should not include the domain to authenticate with. * For example: "user" is correct whereas "DOMAIN\\user" is not. * @param password The password. * @param host The host the authentication request is originating from. Essentially, the * computer name for this machine. * @param domain The domain to authenticate within. */ --- core/src/main/java/hudson/ProxyConfiguration.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/ProxyConfiguration.java b/core/src/main/java/hudson/ProxyConfiguration.java index 7c2809c53f..3baea805d4 100644 --- a/core/src/main/java/hudson/ProxyConfiguration.java +++ b/core/src/main/java/hudson/ProxyConfiguration.java @@ -396,7 +396,7 @@ public final class ProxyConfiguration extends AbstractDescribableImpl= 0){ final String domain = userName.substring(0, userName.indexOf('\\')); final String user = userName.substring(userName.indexOf('\\') + 1); - return new NTCredentials(user, Secret.fromString(password).getPlainText(), domain, ""); + return new NTCredentials(user, Secret.fromString(password).getPlainText(), "", domain); } else { return new UsernamePasswordCredentials(userName, Secret.fromString(password).getPlainText()); } -- GitLab