From c0c5b076ec7fa75093bfdb13e0b06a12a46e4a6e Mon Sep 17 00:00:00 2001 From: Jesse Glick Date: Fri, 13 Dec 2013 10:49:57 -0500 Subject: [PATCH] DRY: LogRecorderManager.configDir. --- core/src/main/java/hudson/logging/LogRecorder.java | 2 +- core/src/main/java/hudson/logging/LogRecorderManager.java | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/hudson/logging/LogRecorder.java b/core/src/main/java/hudson/logging/LogRecorder.java index f780252af4..918724bbb4 100644 --- a/core/src/main/java/hudson/logging/LogRecorder.java +++ b/core/src/main/java/hudson/logging/LogRecorder.java @@ -299,7 +299,7 @@ public class LogRecorder extends AbstractModelObject implements Saveable { * The file we save our configuration. */ private XmlFile getConfigFile() { - return new XmlFile(XSTREAM, new File(Jenkins.getInstance().getRootDir(),"log/"+name+".xml")); + return new XmlFile(XSTREAM, new File(LogRecorderManager.configDir(), name + ".xml")); } /** diff --git a/core/src/main/java/hudson/logging/LogRecorderManager.java b/core/src/main/java/hudson/logging/LogRecorderManager.java index ab8337c701..d16ece6c2b 100644 --- a/core/src/main/java/hudson/logging/LogRecorderManager.java +++ b/core/src/main/java/hudson/logging/LogRecorderManager.java @@ -33,7 +33,6 @@ import hudson.model.RSS; import hudson.util.CopyOnWriteMap; import jenkins.model.JenkinsLocationConfiguration; import jenkins.model.ModelObjectWithChildren; -import jenkins.model.ModelObjectWithContextMenu; import jenkins.model.ModelObjectWithContextMenu.ContextMenu; import org.apache.commons.io.filefilter.WildcardFileFilter; import org.kohsuke.stapler.QueryParameter; @@ -52,7 +51,6 @@ import java.util.GregorianCalendar; import java.util.List; import java.util.Locale; import java.util.Map; -import java.util.Map.Entry; import java.util.logging.Level; import java.util.logging.LogRecord; import java.util.logging.Logger; @@ -84,12 +82,16 @@ public class LogRecorderManager extends AbstractModelObject implements ModelObje return logRecorders.get(token); } + static File configDir() { + return new File(Jenkins.getInstance().getRootDir(), "log"); + } + /** * Loads the configuration from disk. */ public void load() throws IOException { logRecorders.clear(); - File dir = new File(Jenkins.getInstance().getRootDir(), "log"); + File dir = configDir(); File[] files = dir.listFiles((FileFilter)new WildcardFileFilter("*.xml")); if(files==null) return; for (File child : files) { -- GitLab