From bf9ee2ecf4a337976e2d44e69ba1e537170d907d Mon Sep 17 00:00:00 2001 From: Jeff Thompson Date: Tue, 7 Jan 2020 12:08:57 -0700 Subject: [PATCH] Address review comments. --- core/src/main/java/hudson/Util.java | 1 + core/src/main/java/jenkins/model/RunIdMigrator.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/Util.java b/core/src/main/java/hudson/Util.java index 7c9f7c5fe7..776fea2c41 100644 --- a/core/src/main/java/hudson/Util.java +++ b/core/src/main/java/hudson/Util.java @@ -623,6 +623,7 @@ public class Util { // TODO JENKINS-60563 remove MD5 from all usages in Jenkins @SuppressFBWarnings(value = "WEAK_MESSAGE_DIGEST_MD5", justification = "This method should only be used for non-security applications where the MD5 weakness is not a problem.") + @Deprecated private static MessageDigest getMd5() throws NoSuchAlgorithmException { return MessageDigest.getInstance("MD5"); } diff --git a/core/src/main/java/jenkins/model/RunIdMigrator.java b/core/src/main/java/jenkins/model/RunIdMigrator.java index 0ec19fb19e..0f08bdfa26 100644 --- a/core/src/main/java/jenkins/model/RunIdMigrator.java +++ b/core/src/main/java/jenkins/model/RunIdMigrator.java @@ -322,7 +322,7 @@ public final class RunIdMigrator { new RunIdMigrator().unmigrateJobsDir(jobs); } - @SuppressFBWarnings(value = "PATH_TRAVERSAL_IN", justification = "Only used as an command-line process.") + @SuppressFBWarnings(value = "PATH_TRAVERSAL_IN", justification = "Only invoked from the command line as a standalone utility") private static File constructFile(String arg) { return new File(arg); } -- GitLab