diff --git a/core/src/main/java/hudson/diagnosis/NullIdDescriptorMonitor.java b/core/src/main/java/hudson/diagnosis/NullIdDescriptorMonitor.java index 8892fb1f2ab98aadda857d19f5654ffc385f7875..b33e36e81b6ebd54e5d3741b8024391185952dc4 100644 --- a/core/src/main/java/hudson/diagnosis/NullIdDescriptorMonitor.java +++ b/core/src/main/java/hudson/diagnosis/NullIdDescriptorMonitor.java @@ -60,7 +60,8 @@ public class NullIdDescriptorMonitor extends AdministrativeMonitor { return Collections.unmodifiableList(problems); } - private void verify() { + @Initializer(after=EXTENSIONS_AUGMENTED) + public void verify() { Jenkins h = Jenkins.getInstance(); for (Descriptor d : h.getExtensionList(Descriptor.class)) { PluginWrapper p = h.getPluginManager().whichPlugin(d.getClass()); @@ -81,10 +82,5 @@ public class NullIdDescriptorMonitor extends AdministrativeMonitor { } } - @Initializer(after=EXTENSIONS_AUGMENTED) - public static void verifyId() { - AdministrativeMonitor.all().get(NullIdDescriptorMonitor.class).verify(); - } - private static final Logger LOGGER = Logger.getLogger(NullIdDescriptorMonitor.class.getName()); } diff --git a/core/src/main/java/jenkins/model/Uptime.java b/core/src/main/java/jenkins/model/Uptime.java index 81cce79374e30de28ea6d6d846d69a096b808f4d..190c678ff7df60f1d9f4022498d5925428b4673c 100644 --- a/core/src/main/java/jenkins/model/Uptime.java +++ b/core/src/main/java/jenkins/model/Uptime.java @@ -27,7 +27,7 @@ public class Uptime { } @Initializer(after=InitMilestone.JOB_LOADED) - public static void init() { - ExtensionList.lookup(Uptime.class).get(0).startTime = System.currentTimeMillis(); + public void init() { + startTime = System.currentTimeMillis(); } } diff --git a/core/src/main/java/jenkins/security/RekeySecretAdminMonitor.java b/core/src/main/java/jenkins/security/RekeySecretAdminMonitor.java index ea96951bcf4927f8ff6d4562b47a0e6a35d6c860..ff0a92a84f8697e4f917fe30dc999d2abfaf81ec 100644 --- a/core/src/main/java/jenkins/security/RekeySecretAdminMonitor.java +++ b/core/src/main/java/jenkins/security/RekeySecretAdminMonitor.java @@ -113,13 +113,11 @@ public class RekeySecretAdminMonitor extends AsynchronousAdministrativeMonitor i @Initializer(fatal=false,after=InitMilestone.PLUGINS_STARTED,before=InitMilestone.EXTENSIONS_AUGMENTED) // as early as possible, but this needs to be late enough that the ConfidentialStore is available - public static void scanOnReboot() throws InterruptedException, IOException, GeneralSecurityException { - RekeySecretAdminMonitor m = new RekeySecretAdminMonitor(); // throw-away instance - - FileBoolean flag = m.scanOnBoot; + public void scanOnReboot() throws InterruptedException, IOException, GeneralSecurityException { + FileBoolean flag = scanOnBoot; if (flag.isOn()) { flag.off(); - m.start(false).join(); + start(false).join(); // block the boot until the rewrite process is complete // don't let the failure in RekeyThread block Jenkins boot. }