From 8b9ca06f496066b49f855b79b630d76f16d076f3 Mon Sep 17 00:00:00 2001 From: Daniel Beck Date: Sat, 8 Feb 2014 23:05:29 +0100 Subject: [PATCH] Added logging when filtering descriptors. --- .../model/DescriptorVisibilityFilter.java | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/model/DescriptorVisibilityFilter.java b/core/src/main/java/hudson/model/DescriptorVisibilityFilter.java index 2dc1be6519..774088bc41 100644 --- a/core/src/main/java/hudson/model/DescriptorVisibilityFilter.java +++ b/core/src/main/java/hudson/model/DescriptorVisibilityFilter.java @@ -9,6 +9,9 @@ import jenkins.model.Jenkins; import java.util.ArrayList; import java.util.List; +import java.util.logging.Logger; +import java.util.logging.Level; + /** * Hides {@link Descriptor}s from users. * @@ -18,6 +21,8 @@ import java.util.List; */ public abstract class DescriptorVisibilityFilter implements ExtensionPoint { + private static final Logger LOGGER = Logger.getLogger(DescriptorVisibilityFilter.class.getName()); + /** * Decides if the given descriptor should be visible to the user. * @@ -46,9 +51,19 @@ public abstract class DescriptorVisibilityFilter implements ExtensionPoint { OUTER: for (T d : source) { + if (LOGGER.isLoggable(Level.FINE)) { + LOGGER.fine("Determining visibility of " + d + " in context " + context); + } for (DescriptorVisibilityFilter f : filters) { - if (!f.filter(context,d)) + if (LOGGER.isLoggable(Level.FINER)) { + LOGGER.finer("Querying " + f + " for visibility of " + d + " in " + context); + } + if (!f.filter(context,d)) { + if (LOGGER.isLoggable(Level.CONFIG)) { + LOGGER.config("Filter " + f + " hides " + d + " in context " + context); + } continue OUTER; // veto-ed. not shown + } } r.add(d); } -- GitLab