* Just like {@link javax.servlet.ServletContext#getContextPath()}, starts with '/' but doesn't end with '/'. + * Unlike {@link WebClient#getContextPath} this is not a complete URL. */ - protected String contextPath = "/jenkins"; + public String contextPath = "/jenkins"; /** * {@link Runnable}s to be invoked at {@link #after()} . @@ -1913,10 +1916,10 @@ public class JenkinsRule implements TestRule, MethodRule, RootAction { } /** - * Requests a page within Hudson. + * Requests an HTML page within Jenkins. * * @param relative - * Relative path within Hudson. Starts without '/'. + * Relative path within Jenkins. Starts without '/'. * For example, "job/test/" to go to a job top page. */ public HtmlPage goTo(String relative) throws IOException, SAXException { @@ -1928,14 +1931,24 @@ public class JenkinsRule implements TestRule, MethodRule, RootAction { } } - public Page goTo(String relative, String expectedContentType) throws IOException, SAXException { + /** + * Requests a page within Jenkins. + * + * @param relative + * Relative path within Jenkins. Starts without '/'. + * For example, "job/test/" to go to a job top page. + * @param expectedContentType the expected {@link WebResponse#getContentType}, or null to do no such check + */ + public Page goTo(String relative, @CheckForNull String expectedContentType) throws IOException, SAXException { assert !relative.startsWith("/"); Page p = super.getPage(getContextPath() + relative); - assertThat(p.getWebResponse().getContentType(), is(expectedContentType)); + if (expectedContentType != null) { + assertThat(p.getWebResponse().getContentType(), is(expectedContentType)); + } return p; } - /** Loads a page as XML. Useful for testing Hudson's xml api, in concert with + /** Loads a page as XML. Useful for testing Jenkins's XML API, in concert with * assertXPath(DomNode page, String xpath) * @param path the path part of the url to visit * @return the XmlPage found at that url @@ -1968,6 +1981,7 @@ public class JenkinsRule implements TestRule, MethodRule, RootAction { /** * Returns the URL of the webapp top page. * URL ends with '/'. + *
This is actually the same as {@link #getURL} and should not be confused with {@link #contextPath}. */ public String getContextPath() throws IOException { return getURL().toExternalForm(); diff --git a/test/src/test/java/lib/layout/LayoutTest.java b/test/src/test/java/lib/layout/LayoutTest.java new file mode 100644 index 0000000000000000000000000000000000000000..a632b18cce9560ada714c78c85878dac3cc9c78a --- /dev/null +++ b/test/src/test/java/lib/layout/LayoutTest.java @@ -0,0 +1,55 @@ +/* + * The MIT License + * + * Copyright 2014 Jesse Glick. + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal + * in the Software without restriction, including without limitation the rights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN + * THE SOFTWARE. + */ + +package lib.layout; + +import com.gargoylesoftware.htmlunit.html.HtmlElement; +import com.gargoylesoftware.htmlunit.html.HtmlLink; +import org.junit.Rule; +import org.junit.Test; +import org.jvnet.hudson.test.Bug; +import org.jvnet.hudson.test.JenkinsRule; +import org.jvnet.hudson.test.recipes.PresetData; + +public class LayoutTest { + + @Rule public JenkinsRule r = new JenkinsRule(); + + @Bug(21254) + @PresetData(PresetData.DataSet.NO_ANONYMOUS_READACCESS) + @Test public void rejectedLinks() throws Exception { + JenkinsRule.WebClient wc = r.createWebClient(); + String prefix = r.contextPath + '/'; + for (HtmlElement e : wc.goTo("login").getElementsByTagName("link")) { + String href = ((HtmlLink) e).getHrefAttribute(); + if (!href.startsWith(prefix)) { + System.err.println("ignoring " + href); + continue; + } + System.err.println("checking " + href); + wc.goTo(href.substring(prefix.length()), null); + } + } + +}