From 73f3ae70f01aa900d654d091dd54860cb7214f71 Mon Sep 17 00:00:00 2001
From: kohsuke <kohsuke@71c3de6d-444a-0410-be80-ed276b4c234a>
Date: Mon, 10 Mar 2008 05:49:55 +0000
Subject: [PATCH] fixed "up" link

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@7482 71c3de6d-444a-0410-be80-ed276b4c234a
---
 core/pom.xml                                  |  2 +-
 .../main/java/hudson/matrix/MatrixRun.java    | 14 +++++++++++++
 .../main/java/hudson/maven/MavenBuild.java    | 17 +++++++++++++++
 .../main/java/hudson/model/AbstractBuild.java | 21 +++++++++++++++++++
 .../model/AbstractBuild/sidepanel.jelly       |  2 +-
 5 files changed, 54 insertions(+), 2 deletions(-)

diff --git a/core/pom.xml b/core/pom.xml
index 207c23746d..2df7c4190b 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -274,7 +274,7 @@
     <dependency>
       <groupId>org.kohsuke.stapler</groupId>
       <artifactId>stapler</artifactId>
-      <version>1.62</version>
+      <version>1.63</version>
     </dependency>
     <dependency>
       <groupId>org.kohsuke</groupId>
diff --git a/core/src/main/java/hudson/matrix/MatrixRun.java b/core/src/main/java/hudson/matrix/MatrixRun.java
index 08fca765f2..d8e7bb35d4 100644
--- a/core/src/main/java/hudson/matrix/MatrixRun.java
+++ b/core/src/main/java/hudson/matrix/MatrixRun.java
@@ -31,6 +31,20 @@ public class MatrixRun extends Build<MatrixConfiguration,MatrixRun> {
         super(project, buildDir);
     }
 
+    public String getUpUrl() {
+        StaplerRequest req = Stapler.getCurrentRequest();
+        if(req!=null) {
+            List<Ancestor> ancs = req.getAncestors();
+            for( int i=1; i<ancs.size(); i++) {
+                if(ancs.get(i).getObject()==this) {
+                    if(ancs.get(i-1).getObject() instanceof MatrixBuild) {
+                        return ancs.get(i-1).getUrl()+'/';
+                    }
+                }
+            }
+        }
+        return super.getDisplayName();
+    }
 
     public String getDisplayName() {
         StaplerRequest req = Stapler.getCurrentRequest();
diff --git a/core/src/main/java/hudson/maven/MavenBuild.java b/core/src/main/java/hudson/maven/MavenBuild.java
index 9d30bdf2a2..806c0a854c 100644
--- a/core/src/main/java/hudson/maven/MavenBuild.java
+++ b/core/src/main/java/hudson/maven/MavenBuild.java
@@ -71,6 +71,23 @@ public class MavenBuild extends AbstractBuild<MavenModule,MavenBuild> {
         super(project, buildDir);
     }
 
+    @Override
+    public String getUpUrl() {
+        StaplerRequest req = Stapler.getCurrentRequest();
+        if(req!=null) {
+            List<Ancestor> ancs = req.getAncestors();
+            for( int i=1; i<ancs.size(); i++) {
+                if(ancs.get(i).getObject()==this) {
+                    if(ancs.get(i-1).getObject() instanceof MavenModuleSetBuild) {
+                        // if under MavenModuleSetBuild, "up" means MMSB
+                        return ancs.get(i-1).getUrl()+'/';
+                    }
+                }
+            }
+        }
+        return super.getUpUrl();
+    }
+
     @Override
     public String getDisplayName() {
         StaplerRequest req = Stapler.getCurrentRequest();
diff --git a/core/src/main/java/hudson/model/AbstractBuild.java b/core/src/main/java/hudson/model/AbstractBuild.java
index 2769abd6c1..debd48cdc9 100644
--- a/core/src/main/java/hudson/model/AbstractBuild.java
+++ b/core/src/main/java/hudson/model/AbstractBuild.java
@@ -3,7 +3,9 @@ package hudson.model;
 import hudson.Launcher;
 import hudson.Proc.LocalProc;
 import hudson.Util;
+import hudson.Functions;
 import hudson.matrix.MatrixConfiguration;
+import hudson.matrix.MatrixRun;
 import hudson.maven.MavenBuild;
 import hudson.model.Fingerprint.BuildPtr;
 import hudson.model.Fingerprint.RangeSet;
@@ -23,6 +25,7 @@ import hudson.util.AdaptedIterator;
 import hudson.util.Iterators;
 import org.kohsuke.stapler.StaplerRequest;
 import org.kohsuke.stapler.StaplerResponse;
+import org.kohsuke.stapler.Stapler;
 import org.kohsuke.stapler.export.Exported;
 import org.xml.sax.SAXException;
 
@@ -42,6 +45,8 @@ import java.util.List;
 import java.util.Map;
 import java.util.Set;
 
+import sun.misc.Request;
+
 /**
  * Base implementation of {@link Run}s that build software.
  *
@@ -123,6 +128,22 @@ public abstract class AbstractBuild<P extends AbstractProject<P,R>,R extends Abs
         return builtOn;
     }
 
+    /**
+     * Used to render the side panel "Back to project" link.
+     *
+     * <p>
+     * In a rare situation where a build can be reached from multiple paths,
+     * returning different URLs from this method based on situations might
+     * be desirable.
+     *
+     * <p>
+     * If you override this method, you'll most likely also want to override
+     * {@link #getDisplayName()}.
+     */
+    public String getUpUrl() {
+        return Functions.getNearestAncestorUrl(Stapler.getCurrentRequest(),getParent())+'/';
+    }
+
     /**
      * List of users who committed a change since the last non-broken build till now.
      *
diff --git a/core/src/main/resources/hudson/model/AbstractBuild/sidepanel.jelly b/core/src/main/resources/hudson/model/AbstractBuild/sidepanel.jelly
index 89f8780b8f..5a5143f89f 100644
--- a/core/src/main/resources/hudson/model/AbstractBuild/sidepanel.jelly
+++ b/core/src/main/resources/hudson/model/AbstractBuild/sidepanel.jelly
@@ -6,7 +6,7 @@
   <l:side-panel>
     <l:tasks>
       <j:set var="buildUrl" value="${h.decompose(request)}" />
-      <l:task icon="images/24x24/up.gif" href="${h.getNearestAncestorUrl(request,it.parent)}/" title="${%Back to Project}" />
+      <l:task icon="images/24x24/up.gif" href="${it.upUrl}" title="${%Back to Project}" />
       <l:task icon="images/24x24/search.gif" href="${buildUrl.baseUrl}/" title="${%Status}" />
       <l:task icon="images/24x24/notepad.gif" href="${buildUrl.baseUrl}/changes" title="${%Changes}" />
       <j:choose>
-- 
GitLab