From 6c54eb24947c5eaae8b7cb6929444c40a6b735de Mon Sep 17 00:00:00 2001
From: kohsuke <kohsuke@71c3de6d-444a-0410-be80-ed276b4c234a>
Date: Thu, 27 Sep 2007 15:28:19 +0000
Subject: [PATCH] bug fix.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@4943 71c3de6d-444a-0410-be80-ed276b4c234a
---
 core/src/main/java/hudson/model/Hudson.java |  2 +-
 core/src/main/java/hudson/model/User.java   | 14 +++++++++-----
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/core/src/main/java/hudson/model/Hudson.java b/core/src/main/java/hudson/model/Hudson.java
index 36b941a321..d8beb2c7dd 100644
--- a/core/src/main/java/hudson/model/Hudson.java
+++ b/core/src/main/java/hudson/model/Hudson.java
@@ -701,7 +701,7 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node
                 protected Collection<Computer> all() { return computers.values(); }
             })
             .add(new CollectionSearchIndex() {// for users
-                protected User get(String key) { return getUser(key); }
+                protected User get(String key) { return User.get(key,false); }
                 protected Collection<User> all() { return User.getAll(); }
             })
             .add(new CollectionSearchIndex() {// for views
diff --git a/core/src/main/java/hudson/model/User.java b/core/src/main/java/hudson/model/User.java
index e22fbd0ef4..95a2a3d4e0 100644
--- a/core/src/main/java/hudson/model/User.java
+++ b/core/src/main/java/hudson/model/User.java
@@ -159,17 +159,14 @@ public class User extends AbstractModelObject {
         return get("unknown");
     }
 
-    /**
-     * Gets the {@link User} object by its id.
-     */
-    public static User get(String id) {
+    public static User get(String id, boolean create) {
         if(id==null)
             return null;
         id = id.replace('\\', '_').replace('/', '_');
         
         synchronized(byName) {
             User u = byName.get(id);
-            if(u==null) {
+            if(u==null && create) {
                 u = new User(id);
                 byName.put(id,u);
             }
@@ -177,6 +174,13 @@ public class User extends AbstractModelObject {
         }
     }
 
+    /**
+     * Gets the {@link User} object by its id.
+     */
+    public static User get(String id) {
+        return get(id,true);
+    }
+
     /**
      * Gets all the users.
      */
-- 
GitLab