From 6851883e8f931c6a6e2395c347e1e3f96b489a2b Mon Sep 17 00:00:00 2001
From: kohsuke <kohsuke@71c3de6d-444a-0410-be80-ed276b4c234a>
Date: Sat, 21 Mar 2009 00:19:53 +0000
Subject: [PATCH] noting why I'm doing a null check.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16422 71c3de6d-444a-0410-be80-ed276b4c234a
---
 core/src/main/java/hudson/triggers/Trigger.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/core/src/main/java/hudson/triggers/Trigger.java b/core/src/main/java/hudson/triggers/Trigger.java
index 28f83a2027..1ff4d1c497 100644
--- a/core/src/main/java/hudson/triggers/Trigger.java
+++ b/core/src/main/java/hudson/triggers/Trigger.java
@@ -276,6 +276,8 @@ public abstract class Trigger<J extends Item> implements Describable<Trigger<?>>
 
             if (i instanceof TopLevelItem) {// ugly
                 TopLevelItemDescriptor tld = ((TopLevelItem) i).getDescriptor();
+                // tld shouldn't be really null in contract, but we often write test Describables that
+                // doesn't have a Descriptor.
                 if(tld!=null && !tld.isApplicable(t))    continue;
             }
 
-- 
GitLab