From 679c127f74176cf8d321f71cf7622663950ab45b Mon Sep 17 00:00:00 2001 From: tfennelly Date: Mon, 1 Dec 2014 11:03:25 +0000 Subject: [PATCH] Model link on build name in build history --- .../hudson/widgets/HistoryWidget/entry.jelly | 4 ++-- .../main/resources/lib/layout/breadcrumbs.js | 14 ++++++++++++-- core/src/main/resources/lib/layout/pane.jelly | 2 +- war/src/main/webapp/css/style.css | 8 ++++---- war/src/main/webapp/scripts/hudson-behavior.js | 18 ++++++++++++++++++ 5 files changed, 37 insertions(+), 9 deletions(-) diff --git a/core/src/main/resources/hudson/widgets/HistoryWidget/entry.jelly b/core/src/main/resources/hudson/widgets/HistoryWidget/entry.jelly index 2283a6603a..44e3f664e3 100644 --- a/core/src/main/resources/hudson/widgets/HistoryWidget/entry.jelly +++ b/core/src/main/resources/hudson/widgets/HistoryWidget/entry.jelly @@ -35,10 +35,10 @@ THE SOFTWARE.
- ${build.displayName} + ${build.displayName}
- + diff --git a/core/src/main/resources/lib/layout/breadcrumbs.js b/core/src/main/resources/lib/layout/breadcrumbs.js index a36686a0c6..90b019f620 100644 --- a/core/src/main/resources/lib/layout/breadcrumbs.js +++ b/core/src/main/resources/lib/layout/breadcrumbs.js @@ -93,6 +93,7 @@ var breadcrumbs = (function() { var menuSelector = (function() { var menuSelector = $(document.createElement("div")); var menuSelectorTarget; + var parentToUpdate; document.body.appendChild(menuSelector); menuSelector.id = 'menuSelector'; @@ -121,10 +122,15 @@ var breadcrumbs = (function() { this.style.visibility = "visible"; menuSelectorTarget = target; + var updateParentSelector = menuSelectorTarget.getAttribute('update-parent-class'); + if (updateParentSelector) { + parentToUpdate = $(menuSelectorTarget).up(updateParentSelector); + } }; menuSelector.hide = function() { this.style.visibility = "hidden"; menuSelectorTarget = undefined; + parentToUpdate = undefined; }; menuSelector.observe("click",function () { invokeContextMenu(this.target); @@ -137,16 +143,20 @@ var breadcrumbs = (function() { }.bind(menuSelector), 750); menuSelector.observe("mouseover",function () { - logger("mouse entered 'v'"); if (menuSelectorTarget) { + if (parentToUpdate) { + parentToUpdate.addClassName('model-link-active'); + } menuSelectorTarget.addClassName('mouseIsOverMenuSelector'); } canceller.cancel(); }); menuSelector.observe("mouseout",function () { - logger("mouse left 'v'"); canceller.schedule(); if (menuSelectorTarget) { + if (parentToUpdate) { + parentToUpdate.removeClassName('model-link-active'); + } menuSelectorTarget.removeClassName('mouseIsOverMenuSelector'); } }); diff --git a/core/src/main/resources/lib/layout/pane.jelly b/core/src/main/resources/lib/layout/pane.jelly index 3196313ece..38d7e767b9 100644 --- a/core/src/main/resources/lib/layout/pane.jelly +++ b/core/src/main/resources/lib/layout/pane.jelly @@ -48,7 +48,7 @@ THE SOFTWARE. Footer of the box. Can include HTML. -