From 5feda70fde60ffaa09a9b7389d73e98bf7703a0e Mon Sep 17 00:00:00 2001
From: Josh Soref <jsoref@users.noreply.github.com>
Date: Wed, 20 Feb 2019 19:08:27 -0500
Subject: [PATCH] Simplify end of function return logic

---
 core/src/main/java/hudson/model/AbstractProject.java       | 6 +-----
 core/src/main/java/hudson/model/BooleanParameterValue.java | 4 +---
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/core/src/main/java/hudson/model/AbstractProject.java b/core/src/main/java/hudson/model/AbstractProject.java
index 3b60e86185..2f91394f20 100644
--- a/core/src/main/java/hudson/model/AbstractProject.java
+++ b/core/src/main/java/hudson/model/AbstractProject.java
@@ -1450,11 +1450,7 @@ public abstract class AbstractProject<P extends AbstractProject<P,R>,R extends A
                     }
                 }
                 //We can roam, check that the master is set to be used as much as possible, and not tied jobs only.
-                if(Jenkins.getInstance().getMode() == Mode.EXCLUSIVE) {
-                    return true;
-                } else {
-                    return false;
-                }
+                return Jenkins.getInstance().getMode() == Mode.EXCLUSIVE;
             }
         }
         return true;
diff --git a/core/src/main/java/hudson/model/BooleanParameterValue.java b/core/src/main/java/hudson/model/BooleanParameterValue.java
index 9b7b94046b..7d69a903d7 100644
--- a/core/src/main/java/hudson/model/BooleanParameterValue.java
+++ b/core/src/main/java/hudson/model/BooleanParameterValue.java
@@ -79,9 +79,7 @@ public class BooleanParameterValue extends ParameterValue {
 
         BooleanParameterValue that = (BooleanParameterValue) o;
 
-        if (value != that.value) return false;
-
-        return true;
+        return value == that.value;
     }
 
     @Override
-- 
GitLab