From 59d491f9673671e7cd5576710645298216c83628 Mon Sep 17 00:00:00 2001 From: Jesse Glick Date: Mon, 29 Dec 2014 16:16:01 -0500 Subject: [PATCH] Throwable.printStackTrace() to stderr is gratuitous when we are sending the exception to Logger. --- core/src/main/java/hudson/triggers/Trigger.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/core/src/main/java/hudson/triggers/Trigger.java b/core/src/main/java/hudson/triggers/Trigger.java index 36c7fdf7d6..32b4d9b5bc 100644 --- a/core/src/main/java/hudson/triggers/Trigger.java +++ b/core/src/main/java/hudson/triggers/Trigger.java @@ -214,8 +214,7 @@ public abstract class Trigger implements Describable> checkTriggers(cal); } catch (Throwable e) { LOGGER.log(Level.WARNING,"Cron thread throw an exception",e); - // bug in the code. Don't let the thread die. - e.printStackTrace(); + // SafeTimerTask.run would also catch this, but be sure to increment cal too. } cal.add(Calendar.MINUTE,1); -- GitLab