From 40806bb2903465d968003ed5bd00ed5aa27ce393 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Tue, 15 Nov 2011 22:05:55 -0800 Subject: [PATCH] Cyclic dependency check not needed. --- core/src/main/java/hudson/PluginManager.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/PluginManager.java b/core/src/main/java/hudson/PluginManager.java index 2716ce2234..cc49662890 100644 --- a/core/src/main/java/hudson/PluginManager.java +++ b/core/src/main/java/hudson/PluginManager.java @@ -335,7 +335,8 @@ public abstract class PluginManager extends AbstractModelObject { if (getPlugin(p.getShortName())!=null) throw new IllegalArgumentException("Dynamic reloading isn't possible"); - // TODO: check cyclic dependency + // there's no need to do cyclic dependency check, because we are deploying one at a time, + // so existing plugins can't be depending on this newly deployed one. plugins.add(p); activePlugins.add(p); -- GitLab