diff --git a/core/src/main/resources/hudson/model/View/AsynchPeople/index.jelly b/core/src/main/resources/hudson/model/View/AsynchPeople/index.jelly index 1c8a953e57c53db934c853ec3398b589f110a567..109b129507afc2d495986f2b4bd37e6abbf82e44 100644 --- a/core/src/main/resources/hudson/model/View/AsynchPeople/index.jelly +++ b/core/src/main/resources/hudson/model/View/AsynchPeople/index.jelly @@ -41,11 +41,16 @@ THE SOFTWARE. var p = document.getElementById('people'); for (var x = 0; data.length > x; x++) { var e = data[x]; - var r = document.getElementById('person-' + e.id); + var id = 'person-' + e.id; + var r = document.getElementById(id); if (r == null) { r = document.createElement('tr'); - r.id = e.id; + r.id = id; p.appendChild(r); + } else { + while (r.firstChild) { + r.removeChild(r.firstChild); + } } var d = document.createElement('td'); diff --git a/test/src/test/java/hudson/model/AsynchPeopleTest.java b/test/src/test/java/hudson/model/AsynchPeopleTest.java new file mode 100644 index 0000000000000000000000000000000000000000..c83e660e837bdd9121028f5a168d1da91bed5770 --- /dev/null +++ b/test/src/test/java/hudson/model/AsynchPeopleTest.java @@ -0,0 +1,48 @@ +/* + * The MIT License + * + * Copyright 2013 Jesse Glick. + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal + * in the Software without restriction, including without limitation the rights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN + * THE SOFTWARE. + */ + +package hudson.model; + +import com.gargoylesoftware.htmlunit.html.HtmlPage; +import static org.junit.Assert.*; +import org.junit.Rule; +import org.junit.Test; +import org.jvnet.hudson.test.Bug; +import org.jvnet.hudson.test.For; +import org.jvnet.hudson.test.JenkinsRule; + +@For(View.AsynchPeople.class) +public class AsynchPeopleTest { + + @Rule public JenkinsRule j = new JenkinsRule(); + + @Bug(18641) + @Test public void display() throws Exception { + User.get("bob"); + HtmlPage page = j.createWebClient().goTo("asynchPeople"); + assertEquals("display: none;", page.getElementById("status").getAttribute("style")); + assertNotNull(page.getElementById("person-bob")); + } + +}