From 2472b1d8fc306e02c2470ea2185da43776aa1ec5 Mon Sep 17 00:00:00 2001
From: kohsuke <kohsuke@71c3de6d-444a-0410-be80-ed276b4c234a>
Date: Sun, 17 Dec 2006 06:20:55 +0000
Subject: [PATCH] fixed #174. also improved the test result summary display.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1358 71c3de6d-444a-0410-be80-ed276b4c234a
---
 .../tasks/test/AbstractTestResultAction.java       | 14 ++++++++++++++
 .../main/resources/hudson/model/Build/index.jelly  |  7 +++++--
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java b/core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java
index 13473a7e67..1dc14be525 100644
--- a/core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java
+++ b/core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java
@@ -8,6 +8,7 @@ import hudson.util.ChartUtil;
 import hudson.util.DataSetBuilder;
 import hudson.util.ShiftedCategoryAxis;
 import hudson.util.ColorPalette;
+import hudson.Functions;
 import org.jfree.chart.ChartFactory;
 import org.jfree.chart.JFreeChart;
 import org.jfree.chart.axis.CategoryAxis;
@@ -51,6 +52,16 @@ public abstract class AbstractTestResultAction<T extends AbstractTestResultActio
      */
     public abstract int getTotalCount();
 
+    /**
+     * Gets the diff string of failures.
+     */
+    public final String getFailureDiffString() {
+        T prev = getPreviousResult();
+        if(prev==null)  return "";  // no record
+
+        return " / "+Functions.getDiffString(this.getFailCount()-prev.getFailCount());
+    }
+
     public String getDisplayName() {
         return "Test Result";
     }
@@ -63,6 +74,9 @@ public abstract class AbstractTestResultAction<T extends AbstractTestResultActio
         return "clipboard.gif";
     }
 
+    /**
+     * Gets the test result of the previous build, if it's recorded, or null.
+     */
     public T getPreviousResult() {
         return (T)getPreviousResult(getClass());
     }
diff --git a/core/src/main/resources/hudson/model/Build/index.jelly b/core/src/main/resources/hudson/model/Build/index.jelly
index defe1d7678..acfdb40144 100644
--- a/core/src/main/resources/hudson/model/Build/index.jelly
+++ b/core/src/main/resources/hudson/model/Build/index.jelly
@@ -33,14 +33,17 @@
           <t:summary icon="clipboard.gif">
             <a href="testReport/">Latest Test Result</a>
             <j:choose>
+              <j:when test="${tr.totalCount==0}">
+                (no tests)
+              </j:when>
               <j:when test="${tr.failCount==0}">
                 (no failures)
               </j:when>
               <j:when test="${tr.failCount==1}">
-                (1 failure)
+                (1 failure ${tr.failureDiffString})
               </j:when>
               <j:otherwise>
-                (${tr.failCount} failures)
+                (${tr.failCount} failures ${tr.failureDiffString})
               </j:otherwise>
             </j:choose>
           </t:summary>
-- 
GitLab