From 22f2238b23312a54e8e07d6100446d30bfc67d0a Mon Sep 17 00:00:00 2001
From: Kohsuke Kawaguchi <kk@kohsuke.org>
Date: Sat, 18 Jan 2014 16:04:05 -0800
Subject: [PATCH] [JENKINS-16417]

My recommended fix in response to https://github.com/jenkinsci/jenkins/pull/1093. This does not eliminate nor exclude the need for more generic pluggability, but it would at least address the security concern.
---
 changelog.html                           | 3 +++
 core/src/main/java/hudson/model/Run.java | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/changelog.html b/changelog.html
index 1da3264dfe..3bd3b2ae72 100644
--- a/changelog.html
+++ b/changelog.html
@@ -55,6 +55,9 @@ Upcoming changes</a>
 <!-- Record your changes in the trunk here. -->
 <div id="trunk" style="display:none"><!--=TRUNK-BEGIN=-->
 <ul class=image>
+  <li class=bug>
+    Removing the "keep this build forever" lock on a build should require the DELETE permission.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-16417">issue 16417</a>)
   <li class=bug>
     Files added to zip archive are closed properly.
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-20345">issue 20345</a>)
diff --git a/core/src/main/java/hudson/model/Run.java b/core/src/main/java/hudson/model/Run.java
index baffced4b0..d81c6be817 100644
--- a/core/src/main/java/hudson/model/Run.java
+++ b/core/src/main/java/hudson/model/Run.java
@@ -2086,7 +2086,7 @@ public abstract class Run <JobT extends Job<JobT,RunT>,RunT extends Run<JobT,Run
     }
 
     public void keepLog(boolean newValue) throws IOException {
-        checkPermission(UPDATE);
+        checkPermission(newValue ? UPDATE : DELETE);
         keepLog = newValue;
         save();
     }
-- 
GitLab