[CID-1182127] - Resource leak in HsErrPidList constructor.

Signed-off-by: N Oleg Nenashev <o.v.nenashev@gmail.com>

[CID-1182127] - Resource leak in HsErrPidList constructor.
Signed-off-by: N Oleg Nenashev <o.v.nenashev@gmail.com>
21ba31af · Oleg Nenashev · 3a8b81a0 · 21ba31af
显示空白变更内容
内联并排

Showing with 10 addition and 3 deletion

core/src/main/java/jenkins/diagnosis/HsErrPidList.java core/src/main/java/jenkins/diagnosis/HsErrPidList.java +10 -3

未找到文件。
--- a/core/src/main/java/jenkins/diagnosis/HsErrPidList.java
+++ b/core/src/main/java/jenkins/diagnosis/HsErrPidList.java
@@ -47,8 +47,15 @@ public class HsErrPidList extends AdministrativeMonitor {
            return;
        }
        try {
-            FileChannel ch = new FileInputStream(getSecretKeyFile()).getChannel();
+            FileChannel ch = null;
+            try {
+                ch = new FileInputStream(getSecretKeyFile()).getChannel();
                map = ch.map(MapMode.READ_ONLY,0,1);
+            } finally {
+                if (ch != null) {
+                    ch.close();
+                }
+            }
                
            scan("./hs_err_pid%p.log");
            if (Functions.isWindows()) {