From 1584c350df90a2c4903b6b01070cbd145decf9a9 Mon Sep 17 00:00:00 2001
From: kohsuke <kohsuke@71c3de6d-444a-0410-be80-ed276b4c234a>
Date: Tue, 11 Mar 2008 05:30:03 +0000
Subject: [PATCH] eliminating a lock, at the expense of potentially inefficient
 computation.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@7562 71c3de6d-444a-0410-be80-ed276b4c234a
---
 core/src/main/java/hudson/model/Hudson.java | 26 ++++++++++-----------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/core/src/main/java/hudson/model/Hudson.java b/core/src/main/java/hudson/model/Hudson.java
index dcdf81f073..a8931f55fc 100644
--- a/core/src/main/java/hudson/model/Hudson.java
+++ b/core/src/main/java/hudson/model/Hudson.java
@@ -279,7 +279,7 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node,
      */
     private transient final ConcurrentHashMap<String,Label> labels = new ConcurrentHashMap<String,Label>();
     private transient Set<Label> labelSet;
-    private transient Set<Label> dynamicLabels = null;
+    private transient volatile Set<Label> dynamicLabels = null;
 
     public transient final ServletContext servletContext;
 
@@ -1189,22 +1189,22 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node,
      */
     public Set<Label> getDynamicLabels() {
         if (dynamicLabels == null) {
-            synchronized (this) {
-                Computer comp = getComputer("");
-                if (dynamicLabels == null) {
-                    dynamicLabels = new HashSet<Label>();
-                    if (comp != null) {
-                        VirtualChannel channel = comp.getChannel();
-                        if (channel != null) {
-                            for (DynamicLabeler labeler : LabelFinder.LABELERS) {
-                                for (String label : labeler.findLabels(channel)) {
-                                    dynamicLabels.add(getLabel(label));
-                                }
-                            }
+            // in the worst cast, two threads end up doing the same computation twice,
+            // but that won't break the semantics.
+            // OTOH, not locking prevents dead-lock. See #1390
+            Set<Label> r = new HashSet<Label>();
+            Computer comp = getComputer("");
+            if (comp != null) {
+                VirtualChannel channel = comp.getChannel();
+                if (channel != null) {
+                    for (DynamicLabeler labeler : LabelFinder.LABELERS) {
+                        for (String label : labeler.findLabels(channel)) {
+                            r.add(getLabel(label));
                         }
                     }
                 }
             }
+            dynamicLabels = r;
         }
         return dynamicLabels;
     }
-- 
GitLab