Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
jenkins
提交
09693ce7
J
jenkins
项目概览
xxadev
/
jenkins
与 Fork 源项目一致
从无法访问的项目Fork
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
J
jenkins
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
09693ce7
编写于
10月 15, 2013
作者:
O
Oliver Gondža
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[FIXED JENKINS-20057] NPE when issuing set-build-display-name CLI command
上级
3a2aa30a
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
81 addition
and
0 deletion
+81
-0
core/src/main/java/hudson/cli/SetBuildDisplayNameCommand.java
.../src/main/java/hudson/cli/SetBuildDisplayNameCommand.java
+4
-0
test/src/test/java/hudson/cli/SetBuildDisplayNameCommandTest.java
.../test/java/hudson/cli/SetBuildDisplayNameCommandTest.java
+77
-0
未找到文件。
core/src/main/java/hudson/cli/SetBuildDisplayNameCommand.java
浏览文件 @
09693ce7
...
@@ -29,6 +29,10 @@ public class SetBuildDisplayNameCommand extends CLICommand implements Serializab
...
@@ -29,6 +29,10 @@ public class SetBuildDisplayNameCommand extends CLICommand implements Serializab
@Override
@Override
protected
int
run
()
throws
Exception
{
protected
int
run
()
throws
Exception
{
Run
<?,
?>
run
=
job
.
getBuildByNumber
(
number
);
Run
<?,
?>
run
=
job
.
getBuildByNumber
(
number
);
if
(
run
==
null
)
{
stderr
.
format
(
"Build #%d does not exist\n"
,
number
);
return
-
1
;
}
run
.
checkPermission
(
Run
.
UPDATE
);
run
.
checkPermission
(
Run
.
UPDATE
);
if
(
"-"
.
equals
(
displayName
))
{
if
(
"-"
.
equals
(
displayName
))
{
...
...
test/src/test/java/hudson/cli/SetBuildDisplayNameCommandTest.java
0 → 100644
浏览文件 @
09693ce7
/*
* The MIT License
*
* Copyright 2013 Red Hat, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
package
hudson.cli
;
import
static
org
.
hamcrest
.
MatcherAssert
.
assertThat
;
import
static
org
.
hamcrest
.
Matchers
.
containsString
;
import
static
org
.
hamcrest
.
Matchers
.
equalTo
;
import
static
org
.
hamcrest
.
text
.
IsEmptyString
.
isEmptyString
;
import
hudson.model.FreeStyleBuild
;
import
hudson.model.FreeStyleProject
;
import
org.junit.Before
;
import
org.junit.Rule
;
import
org.junit.Test
;
import
org.jvnet.hudson.test.JenkinsRule
;
public
class
SetBuildDisplayNameCommandTest
{
private
CLICommandInvoker
command
;
@Rule
public
final
JenkinsRule
j
=
new
JenkinsRule
();
@Before
public
void
setUp
()
{
command
=
new
CLICommandInvoker
(
j
,
new
SetBuildDisplayNameCommand
());
}
@Test
public
void
referencingBuildThatDoesNotExistsShouldFail
()
throws
Exception
{
j
.
createFreeStyleProject
(
"project"
);
final
CLICommandInvoker
.
Result
result
=
command
.
invokeWithArgs
(
"project"
,
"42"
,
"DisplayName"
)
;
assertThat
(
result
.
stderr
(),
containsString
(
"Build #42 does not exist"
));
assertThat
(
"No output expected"
,
result
.
stdout
(),
isEmptyString
());
assertThat
(
"Command is expected to fail"
,
result
.
returnCode
(),
equalTo
(-
1
));
}
@Test
public
void
setDescriptionSuccesfully
()
throws
Exception
{
FreeStyleProject
job
=
j
.
createFreeStyleProject
(
"project"
);
FreeStyleBuild
build
=
job
.
scheduleBuild2
(
0
).
get
();
final
CLICommandInvoker
.
Result
result
=
command
.
invokeWithArgs
(
"project"
,
"1"
,
"DisplayName"
)
;
assertThat
(
"No output expected"
,
result
.
stdout
(),
isEmptyString
());
assertThat
(
"No error output expected"
,
result
.
stderr
(),
isEmptyString
());
assertThat
(
"Command is expected to succeed"
,
result
.
returnCode
(),
equalTo
(
0
));
assertThat
(
build
.
getDisplayName
(),
equalTo
(
"DisplayName"
));
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录