From 03f581372cedb020eb1cd04c68e50e006c29da7f Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Fri, 12 Aug 2011 14:21:48 -0700 Subject: [PATCH] regression in eafdaa44a00d838711eb7a4cae324698342efb4c --- core/src/main/java/hudson/model/Queue.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/hudson/model/Queue.java b/core/src/main/java/hudson/model/Queue.java index dcaf248c70..5f99cdaf8d 100644 --- a/core/src/main/java/hudson/model/Queue.java +++ b/core/src/main/java/hudson/model/Queue.java @@ -890,7 +890,7 @@ public class Queue extends ResourceController implements Saveable { * and instead stay in the {@link #blockedProjects} state. */ private boolean isBuildBlocked(Item i) { - if (i.task.isBuildBlocked() || !canRun(i.task.getResourceList()) || !allowNewBuildableTask(i.task)) + if (i.task.isBuildBlocked() || !canRun(i.task.getResourceList())) return true; for (QueueTaskDispatcher d : QueueTaskDispatcher.all()) { @@ -935,7 +935,7 @@ public class Queue extends ResourceController implements Saveable { Iterator itr = blockedProjects.values().iterator(); while (itr.hasNext()) { BlockedItem p = itr.next(); - if (!isBuildBlocked(p)) { + if (!isBuildBlocked(p) && allowNewBuildableTask(p.task)) { // ready to be executed LOGGER.fine(p.task.getFullDisplayName() + " no longer blocked"); itr.remove(); @@ -951,7 +951,7 @@ public class Queue extends ResourceController implements Saveable { waitingList.remove(top); Task p = top.task; - if (!isBuildBlocked(top)) { + if (!isBuildBlocked(top) && allowNewBuildableTask(p)) { // ready to be executed immediately LOGGER.fine(p.getFullDisplayName() + " ready to build"); makeBuildable(new BuildableItem(top)); -- GitLab