From be5a4033c0c7de6247c02dc3ab76b634ac19d4c6 Mon Sep 17 00:00:00 2001 From: sceneq Date: Mon, 16 May 2022 22:05:22 +0900 Subject: [PATCH] This closes #1229, rename ErrMaxFileNameLength to ErrMaxFilePathLength (#1230) Co-authored-by: sceneq --- errors.go | 4 ++-- excelize_test.go | 2 +- file.go | 4 ++-- xmlDrawing.go | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/errors.go b/errors.go index c9d18cb..64fc711 100644 --- a/errors.go +++ b/errors.go @@ -109,9 +109,9 @@ var ( // ErrWorkbookExt defined the error message on receive an unsupported // workbook extension. ErrWorkbookExt = errors.New("unsupported workbook extension") - // ErrMaxFileNameLength defined the error message on receive the file name + // ErrMaxFilePathLength defined the error message on receive the file path // length overflow. - ErrMaxFileNameLength = errors.New("file name length exceeds maximum limit") + ErrMaxFilePathLength = errors.New("file path length exceeds maximum limit") // ErrEncrypt defined the error message on encryption spreadsheet. ErrEncrypt = errors.New("not support encryption currently") // ErrUnknownEncryptMechanism defined the error message on unsupported diff --git a/excelize_test.go b/excelize_test.go index 389573e..27badc6 100644 --- a/excelize_test.go +++ b/excelize_test.go @@ -170,7 +170,7 @@ func TestOpenFile(t *testing.T) { assert.NoError(t, f.SetCellStr("Sheet2", "c"+strconv.Itoa(i), strconv.Itoa(i))) } assert.NoError(t, f.SaveAs(filepath.Join("test", "TestOpenFile.xlsx"))) - assert.EqualError(t, f.SaveAs(filepath.Join("test", strings.Repeat("c", 199), ".xlsx")), ErrMaxFileNameLength.Error()) + assert.EqualError(t, f.SaveAs(filepath.Join("test", strings.Repeat("c", 199), ".xlsx")), ErrMaxFilePathLength.Error()) assert.NoError(t, f.Close()) } diff --git a/file.go b/file.go index 9707a79..1d3360e 100644 --- a/file.go +++ b/file.go @@ -66,8 +66,8 @@ func (f *File) Save() error { // SaveAs provides a function to create or update to a spreadsheet at the // provided path. func (f *File) SaveAs(name string, opt ...Options) error { - if len(name) > MaxFileNameLength { - return ErrMaxFileNameLength + if len(name) > MaxFilePathLength { + return ErrMaxFilePathLength } f.Path = name contentType, ok := map[string]string{ diff --git a/xmlDrawing.go b/xmlDrawing.go index 0b6df05..db5d750 100644 --- a/xmlDrawing.go +++ b/xmlDrawing.go @@ -103,7 +103,7 @@ const ( StreamChunkSize = 1 << 24 MaxFontFamilyLength = 31 MaxFontSize = 409 - MaxFileNameLength = 207 + MaxFilePathLength = 207 MaxFieldLength = 255 MaxColumnWidth = 255 MaxRowHeight = 409 -- GitLab