From ef37997608dfa5ad457961e0f3e427315ba4be83 Mon Sep 17 00:00:00 2001 From: antirez Date: Thu, 24 May 2012 11:35:21 +0200 Subject: [PATCH] Dead code removed from replication.c. The user @jokea noticed that the following line of code into replication.c made little sense: addReplySds(slave,sdsempty()); Investigating a bit I found that this was introduced by commit 6208b3a7 three years ago in the early stages of Redis. The code apparently is not useful at all, so I'm removing it. This change will not be backported into 2.4 so that in the rare case this should introduce a bug, we'll have a chance to detect it into the development branch. However following the code path it seems like the code is not useful at all, so the risk is truly small. --- src/replication.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/replication.c b/src/replication.c index 5c5bc9abf..8eb36f837 100644 --- a/src/replication.c +++ b/src/replication.c @@ -194,7 +194,6 @@ void sendBulkToSlave(aeEventLoop *el, int fd, void *privdata, int mask) { freeClient(slave); return; } - addReplySds(slave,sdsempty()); redisLog(REDIS_NOTICE,"Synchronization with slave succeeded"); } } -- GitLab