From 7a1fd61e3d3d7572ff7825f337206c19c992a83b Mon Sep 17 00:00:00 2001 From: antirez Date: Fri, 14 Jan 2011 10:20:02 +0100 Subject: [PATCH] implemented two new INFO fields showing the size of clients max input and output buffers. --- src/networking.c | 19 +++++++++++++++++++ src/redis.c | 5 +++++ src/redis.h | 2 ++ 3 files changed, 26 insertions(+) diff --git a/src/networking.c b/src/networking.c index 6d232ecf7..55daff85d 100644 --- a/src/networking.c +++ b/src/networking.c @@ -820,3 +820,22 @@ void readQueryFromClient(aeEventLoop *el, int fd, void *privdata, int mask) { } processInputBuffer(c); } + +void getClientsMaxBuffers(unsigned long *longest_output_list, + unsigned long *biggest_input_buffer) { + redisClient *c; + listNode *ln; + listIter li; + unsigned long lol = 0, bib = 0; + + listRewind(server.clients,&li); + while ((ln = listNext(&li)) != NULL) { + c = listNodeValue(ln); + + if (listLength(c->reply) > lol) lol = listLength(c->reply); + if (sdslen(c->querybuf) > bib) bib = sdslen(c->querybuf); + } + *longest_output_list = lol; + *biggest_input_buffer = bib; +} + diff --git a/src/redis.c b/src/redis.c index 4f676a480..5aabe3bcb 100644 --- a/src/redis.c +++ b/src/redis.c @@ -1148,9 +1148,11 @@ sds genRedisInfoString(void) { int j; char hmem[64]; struct rusage self_ru, c_ru; + unsigned long lol, bib; getrusage(RUSAGE_SELF, &self_ru); getrusage(RUSAGE_CHILDREN, &c_ru); + getClientsMaxBuffers(&lol,&bib); bytesToHuman(hmem,zmalloc_used_memory()); info = sdscatprintf(sdsempty(), @@ -1169,6 +1171,8 @@ sds genRedisInfoString(void) { "used_cpu_user_childrens:%.2f\r\n" "connected_clients:%d\r\n" "connected_slaves:%d\r\n" + "client_longest_output_list:%lu\r\n" + "client_biggest_input_buf:%lu\r\n" "blocked_clients:%d\r\n" "used_memory:%zu\r\n" "used_memory_human:%s\r\n" @@ -1208,6 +1212,7 @@ sds genRedisInfoString(void) { (float)c_ru.ru_stime.tv_sec+(float)c_ru.ru_stime.tv_usec/1000000, listLength(server.clients)-listLength(server.slaves), listLength(server.slaves), + lol, bib, server.bpop_blocked_clients, zmalloc_used_memory(), hmem, diff --git a/src/redis.h b/src/redis.h index c5fd7a763..bbcdb4552 100644 --- a/src/redis.h +++ b/src/redis.h @@ -661,6 +661,8 @@ void addReplyDouble(redisClient *c, double d); void addReplyLongLong(redisClient *c, long long ll); void addReplyMultiBulkLen(redisClient *c, long length); void *dupClientReplyValue(void *o); +void getClientsMaxBuffers(unsigned long *longest_output_list, + unsigned long *biggest_input_buffer); #ifdef __GNUC__ void addReplyErrorFormat(redisClient *c, const char *fmt, ...) -- GitLab