From 5d93759072fc58f2e55f4bac147ec809a0106fda Mon Sep 17 00:00:00 2001 From: pissang Date: Thu, 20 Feb 2020 22:49:58 +0800 Subject: [PATCH] fix(radar): optimize ticks calculation when min/max is not defined. Fix value may excced min caused by https://github.com/apache/incubator-echarts/pull/11841 --- src/coord/radar/Radar.js | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/coord/radar/Radar.js b/src/coord/radar/Radar.js index aebc896bc..818e036a0 100644 --- a/src/coord/radar/Radar.js +++ b/src/coord/radar/Radar.js @@ -195,6 +195,7 @@ Radar.prototype.update = function (ecModel, api) { var fixedMax = axisModel.getMax(); var interval = scale.getInterval(); + if (fixedMin != null && fixedMax != null) { // User set min, max, divide to get new interval scale.setExtent(+fixedMin, +fixedMax); @@ -230,13 +231,10 @@ Radar.prototype.update = function (ecModel, api) { if (nicedSplitNumber > splitNumber) { interval = increaseInterval(interval); } - // PENDING - var center = Math.ceil((rawExtent[0] + rawExtent[1]) / 2 / interval) * interval; - var halfSplitNumber = Math.round(splitNumber / 2); - scale.setExtent( - numberUtil.round(center - halfSplitNumber * interval), - numberUtil.round(center + (splitNumber - halfSplitNumber) * interval) - ); + // TODO + var max = Math.ceil(rawExtent[1] / interval) * interval; + var min = numberUtil.round(max - interval * splitNumber); + scale.setExtent(min, max); scale.setInterval(interval); } }); -- GitLab