diff --git a/components/finsh/KConfig b/components/finsh/KConfig index e735517f4b8943decac69d22e425ece01e6d7e91..7b69f0e6b80081fe58d4a1d3ff25ec78956077b4 100644 --- a/components/finsh/KConfig +++ b/components/finsh/KConfig @@ -6,6 +6,10 @@ config RT_USING_FINSH if RT_USING_FINSH +config FINSH_USING_HISTORY + bool "Enable command history feature" + default y + config FINSH_USING_SYMTAB bool "Using symbol table for commands" default y @@ -18,18 +22,25 @@ config FINSH_THREAD_STACK_SIZE int "The stack size for finsh thread" default 4096 +config FINSH_CMD_SIZE + int "The command line size for shell" + default 80 + config FINSH_USING_AUTH bool "shell support authentication" default n - + +if FINSH_USING_AUTH config FINSH_DEFAULT_PASSWORD string "The default password for shell authentication" default "rtthread" +endif config FINSH_USING_MSH bool "Using module shell" default y +if FINSH_USING_MSH config FINSH_USING_MSH_DEFAULT bool "Using module shell in default" default y @@ -37,6 +48,7 @@ config FINSH_USING_MSH_DEFAULT config FINSH_USING_MSH_ONLY bool "Only using module shell" default n +endif endif diff --git a/components/finsh/cmd.c b/components/finsh/cmd.c index ae006238914fe9d4c8568898fc97753e15175917..9197c90ad1cfad9416fb53f2503a73d51e18f9b7 100644 --- a/components/finsh/cmd.c +++ b/components/finsh/cmd.c @@ -121,13 +121,15 @@ static long _list_thread(struct rt_list_node *list) rt_kprintf( " --- ------- ---------- ---------- ------ ---------- ---\n"); for (node = list->next; node != list; node = node->next) { + rt_uint8_t stat; thread = rt_list_entry(node, struct rt_thread, list); rt_kprintf("%-*.*s %3d ", maxlen, RT_NAME_MAX, thread->name, thread->current_priority); - if (thread->stat == RT_THREAD_READY) rt_kprintf(" ready "); - else if (thread->stat == RT_THREAD_SUSPEND) rt_kprintf(" suspend"); - else if (thread->stat == RT_THREAD_INIT) rt_kprintf(" init "); - else if (thread->stat == RT_THREAD_CLOSE) rt_kprintf(" close "); + stat = (thread->stat & RT_THREAD_STAT_MASK); + if (stat == RT_THREAD_READY) rt_kprintf(" ready "); + else if (stat == RT_THREAD_SUSPEND) rt_kprintf(" suspend"); + else if (stat == RT_THREAD_INIT) rt_kprintf(" init "); + else if (stat == RT_THREAD_CLOSE) rt_kprintf(" close "); ptr = (rt_uint8_t *)thread->stack_addr; while (*ptr == '#')ptr ++; @@ -613,14 +615,17 @@ int list_mod_detail(const char *name) /* list main thread in module */ if (module->module_thread != RT_NULL) { + rt_uint8_t stat; + rt_kprintf("main thread pri status sp stack size max used left tick error\n"); rt_kprintf("------------- ---- ------- ---------- ---------- ---------- ---------- ---\n"); thread = module->module_thread; rt_kprintf("%-8.*s 0x%02x", RT_NAME_MAX, thread->name, thread->current_priority); - if (thread->stat == RT_THREAD_READY) rt_kprintf(" ready "); - else if (thread->stat == RT_THREAD_SUSPEND) rt_kprintf(" suspend"); - else if (thread->stat == RT_THREAD_INIT) rt_kprintf(" init "); + stat = (thread->stat & RT_THREAD_STAT_MASK); + if (stat == RT_THREAD_READY) rt_kprintf(" ready "); + else if (stat == RT_THREAD_SUSPEND) rt_kprintf(" suspend"); + else if (stat == RT_THREAD_INIT) rt_kprintf(" init "); ptr = (rt_uint8_t *)thread->stack_addr; while (*ptr == '#')ptr ++; diff --git a/components/finsh/finsh.h b/components/finsh/finsh.h index e80eaab1781e10acb13082a149f927e7fee2cc42..2c7815522cbee6fe8dd0865040b8bb0374b5cf7c 100644 --- a/components/finsh/finsh.h +++ b/components/finsh/finsh.h @@ -56,38 +56,12 @@ /* -- the end of option -- */ -#if defined(RT_USING_NEWLIB) || defined (RT_USING_MINILIBC) -#include -#include -#else -typedef unsigned char u_char; -typedef unsigned short u_short; -typedef unsigned long u_long; - -#if !defined(__CC_ARM) && \ - !defined(__IAR_SYSTEMS_ICC__) && \ - !defined(__ADSPBLACKFIN__) && \ - !defined(_MSC_VER) - -/* only for GNU GCC */ - -#if !(defined(__GNUC__) && defined(__x86_64__)) -typedef unsigned int size_t; -#else +/* std header file */ #include -#endif - -#ifndef NULL -#define NULL RT_NULL -#endif - -#else -/* use libc of armcc */ #include #include +#include #include -#endif -#endif #define FINSH_VERSION_MAJOR 1 #define FINSH_VERSION_MINOR 0 @@ -144,7 +118,7 @@ struct finsh_sysvar #if defined(FINSH_USING_DESCRIPTION) && defined(FINSH_USING_SYMTAB) const char* desc; /* description of system variable */ #endif - u_char type; /* the type of variable */ + uint8_t type; /* the type of variable */ void* var ; /* the address of variable */ }; @@ -360,16 +334,16 @@ struct finsh_token char replay; int position; - u_char current_token; + uint8_t current_token; union { char char_value; int int_value; long long_value; } value; - u_char string[FINSH_STRING_MAX]; + uint8_t string[FINSH_STRING_MAX]; - u_char* line; + uint8_t* line; }; #define FINSH_IDTYPE_VAR 0x01 @@ -378,9 +352,9 @@ struct finsh_token #define FINSH_IDTYPE_ADDRESS 0x08 struct finsh_node { - u_char node_type; /* node node_type */ - u_char data_type; /* node data node_type */ - u_char idtype; /* id node information */ + uint8_t node_type; /* node node_type */ + uint8_t data_type; /* node data node_type */ + uint8_t idtype; /* id node information */ union { /* value node */ char char_value; @@ -403,7 +377,7 @@ struct finsh_node struct finsh_parser { - u_char* parser_string; + uint8_t* parser_string; struct finsh_token token; struct finsh_node* root; @@ -455,9 +429,9 @@ struct finsh_var* finsh_var_lookup(const char* name); long finsh_stack_bottom(void); /* get error number of finsh */ -u_char finsh_errno(void); +uint8_t finsh_errno(void); /* get error string */ -const char* finsh_error_string(u_char type); +const char* finsh_error_string(uint8_t type); #ifdef RT_USING_HEAP /** @@ -477,6 +451,6 @@ void finsh_syscall_append(const char* name, syscall_func func); * @param type the data type of system variable * @param addr the address of system variable */ -void finsh_sysvar_append(const char* name, u_char type, void* addr); +void finsh_sysvar_append(const char* name, uint8_t type, void* addr); #endif #endif diff --git a/components/finsh/finsh_compiler.c b/components/finsh/finsh_compiler.c index 55b3bcbde91c3efc18510a41cad9381d46377653..cf6bb0fe43fa4930e8459e66b9309cf0e07cc158 100644 --- a/components/finsh/finsh_compiler.c +++ b/components/finsh/finsh_compiler.c @@ -34,7 +34,7 @@ #include "finsh_ops.h" union finsh_value* finsh_compile_sp; /* stack pointer */ -u_char* finsh_compile_pc; /* PC */ +uint8_t* finsh_compile_pc; /* PC */ #define finsh_code_byte(x) do { *finsh_compile_pc = (x); finsh_compile_pc ++; } while(0) #define finsh_code_word(x) do { FINSH_SET16(finsh_compile_pc, x); finsh_compile_pc +=2; } while(0) @@ -210,7 +210,7 @@ static int finsh_compile(struct finsh_node* node) case FINSH_NODE_VALUE_NULL: case FINSH_NODE_VALUE_STRING: finsh_code_byte(FINSH_OP_LD_DWORD); - finsh_code_dword((u_long)node->value.ptr); + finsh_code_dword((uint32_t)node->value.ptr); break; /* arithmetic operation */ @@ -756,7 +756,7 @@ static int finsh_compile(struct finsh_node* node) return 0; } -static int finsh_type_check(struct finsh_node* node, u_char is_addr) +static int finsh_type_check(struct finsh_node* node, uint8_t is_addr) { if (node != NULL) { diff --git a/components/finsh/finsh_error.c b/components/finsh/finsh_error.c index 7ddab3f13b26214fca0f1c15d664cb37fb18d4d0..2515c03e8383e02946ecbcefb8abdb82d36fc0c8 100644 --- a/components/finsh/finsh_error.c +++ b/components/finsh/finsh_error.c @@ -28,7 +28,7 @@ */ #include "finsh_error.h" -u_char global_errno; +uint8_t global_errno; static const char * finsh_error_string_table[] = { @@ -56,19 +56,19 @@ int finsh_error_init() return 0; } -int finsh_error_set(u_char type) +int finsh_error_set(uint8_t type) { global_errno = type; return 0; } -u_char finsh_errno() +uint8_t finsh_errno() { return global_errno; } -const char* finsh_error_string(u_char type) +const char* finsh_error_string(uint8_t type) { return finsh_error_string_table[type]; } diff --git a/components/finsh/finsh_error.h b/components/finsh/finsh_error.h index 72bccfa9e7e929599f681fa7cb1ce3cd600c7f10..bec5d85c27504bae4fa0e04e257530d1043f421a 100644 --- a/components/finsh/finsh_error.h +++ b/components/finsh/finsh_error.h @@ -34,9 +34,9 @@ int finsh_error_init(void); /* get error number */ -u_char finsh_errno(void); +uint8_t finsh_errno(void); -int finsh_error_set(u_char type); -const char* finsh_error_string(u_char type); +int finsh_error_set(uint8_t type); +const char* finsh_error_string(uint8_t type); #endif diff --git a/components/finsh/finsh_heap.c b/components/finsh/finsh_heap.c index 06274e79f7bd668fc8d7aec695bcbb266bb0f2a3..28ca78bcfb9138a7f5a89b0f8c8fadcb12dc767e 100644 --- a/components/finsh/finsh_heap.c +++ b/components/finsh/finsh_heap.c @@ -31,15 +31,15 @@ #include "finsh_var.h" ALIGN(RT_ALIGN_SIZE) -u_char finsh_heap[FINSH_HEAP_MAX]; +uint8_t finsh_heap[FINSH_HEAP_MAX]; struct finsh_block_header { - u_long length; + uint32_t length; struct finsh_block_header* next; }; #define BLOCK_HEADER(x) (struct finsh_block_header*)(x) -#define finsh_block_get_header(data) (struct finsh_block_header*)((u_char*)data - sizeof(struct finsh_block_header)) -#define finsh_block_get_data(header) (u_char*)((struct finsh_block_header*)header + 1) +#define finsh_block_get_header(data) (struct finsh_block_header*)((uint8_t*)data - sizeof(struct finsh_block_header)) +#define finsh_block_get_data(header) (uint8_t*)((struct finsh_block_header*)header + 1) #define HEAP_ALIGN_SIZE(size) (((size) + HEAP_ALIGNMENT - 1) & ~(HEAP_ALIGNMENT-1)) static struct finsh_block_header* free_list; @@ -237,7 +237,7 @@ void finsh_block_split(struct finsh_block_header* header, size_t size) * split header into two node: * header->next->... */ - next = BLOCK_HEADER((u_char*)header + sizeof(struct finsh_block_header) + size); + next = BLOCK_HEADER((uint8_t*)header + sizeof(struct finsh_block_header) + size); next->length = header->length - sizeof(struct finsh_block_header) - size; header->length = size; next->next = header->next; @@ -267,13 +267,13 @@ void finsh_block_merge(struct finsh_block_header** list, struct finsh_block_head /* merge to previous node */ if (prev_node != NULL && - ((u_char*)prev_node + prev_node->length + sizeof(struct finsh_block_header) - == (u_char*)header)) + ((uint8_t*)prev_node + prev_node->length + sizeof(struct finsh_block_header) + == (uint8_t*)header)) { /* is it close to next node? */ if ((next_node != NULL) && - ((u_char*)header + header->length + sizeof(struct finsh_block_header) - == (u_char*)next_node)) + ((uint8_t*)header + header->length + sizeof(struct finsh_block_header) + == (uint8_t*)next_node)) { /* merge three node */ prev_node->length += header->length + next_node->length + @@ -289,8 +289,8 @@ void finsh_block_merge(struct finsh_block_header** list, struct finsh_block_head } else /* merge to last node */ if ( (next_node != NULL) && - ((u_char*)header + header->length + sizeof(struct finsh_block_header) - == (u_char*)next_node)) + ((uint8_t*)header + header->length + sizeof(struct finsh_block_header) + == (uint8_t*)next_node)) { header->length += next_node->length + sizeof(struct finsh_block_header); header->next = next_node->next; diff --git a/components/finsh/finsh_node.c b/components/finsh/finsh_node.c index 69357694131ffcddac7662653a018eef9dfa1da6..184ac20d609054f9865b446cb4a3853da680d149 100644 --- a/components/finsh/finsh_node.c +++ b/components/finsh/finsh_node.c @@ -42,7 +42,7 @@ int finsh_node_init() return 0; } -struct finsh_node* finsh_node_allocate(u_char type) +struct finsh_node* finsh_node_allocate(uint8_t type) { int i; @@ -181,7 +181,7 @@ struct finsh_node* finsh_node_new_string(char* s) /* make string */ node->value.ptr = finsh_heap_allocate(strlen(s) + 1); strncpy(node->value.ptr, s, strlen(s)); - ((u_char*)node->value.ptr)[strlen(s)] = '\0'; + ((uint8_t*)node->value.ptr)[strlen(s)] = '\0'; return node; } diff --git a/components/finsh/finsh_node.h b/components/finsh/finsh_node.h index 6dee856c83bf90c60ded78078e7385c6563c26ed..722a36872719c76c99b60e7012163b64715d601c 100644 --- a/components/finsh/finsh_node.h +++ b/components/finsh/finsh_node.h @@ -74,7 +74,7 @@ int finsh_node_init(void); -struct finsh_node* finsh_node_allocate(u_char type); +struct finsh_node* finsh_node_allocate(uint8_t type); struct finsh_node* finsh_node_new_id(char* id); struct finsh_node* finsh_node_new_char(char c); struct finsh_node* finsh_node_new_int(int i); diff --git a/components/finsh/finsh_parser.c b/components/finsh/finsh_parser.c index ffa8ee0d9ba6ec59c395c67480f742019cafa7c8..c937e4247273f0459aa9c70042433784a2d27ed3 100644 --- a/components/finsh/finsh_parser.c +++ b/components/finsh/finsh_parser.c @@ -61,7 +61,7 @@ static struct finsh_node* proc_postfix_expr(struct finsh_parser* self); static struct finsh_node* proc_primary_expr(struct finsh_parser* self); static struct finsh_node* proc_param_list(struct finsh_parser* self); static struct finsh_node* proc_expr_statement(struct finsh_parser* self); -static struct finsh_node* make_sys_node(u_char type, struct finsh_node* node1, +static struct finsh_node* make_sys_node(uint8_t type, struct finsh_node* node1, struct finsh_node* node2); /* check token */ @@ -894,7 +894,7 @@ node1__ \ node2 */ -static struct finsh_node* make_sys_node(u_char type, struct finsh_node* node1, struct finsh_node* node2) +static struct finsh_node* make_sys_node(uint8_t type, struct finsh_node* node1, struct finsh_node* node2) { struct finsh_node* node; @@ -913,7 +913,7 @@ static struct finsh_node* make_sys_node(u_char type, struct finsh_node* node1, s /* start -> statement_expr | decl_variable */ -void finsh_parser_run(struct finsh_parser* self, const u_char* string) +void finsh_parser_run(struct finsh_parser* self, const uint8_t* string) { enum finsh_token_type token; struct finsh_node *node; @@ -921,7 +921,7 @@ void finsh_parser_run(struct finsh_parser* self, const u_char* string) node = NULL; /* init parser */ - self->parser_string = (u_char*)string; + self->parser_string = (uint8_t*)string; /* init token */ finsh_token_init(&(self->token), self->parser_string); diff --git a/components/finsh/finsh_parser.h b/components/finsh/finsh_parser.h index 5f3e95b119b47f6553e43596bb505510620713d9..00d440ae5feeaafaab905a0ca12be2dc70cbb6fb 100644 --- a/components/finsh/finsh_parser.h +++ b/components/finsh/finsh_parser.h @@ -32,6 +32,6 @@ #include int finsh_parser_init(struct finsh_parser* self); -void finsh_parser_run(struct finsh_parser* self, const u_char* string); +void finsh_parser_run(struct finsh_parser* self, const uint8_t* string); #endif diff --git a/components/finsh/finsh_token.c b/components/finsh/finsh_token.c index 799553cd68309b807f36ec5adafcb2bd6c10950f..8b51c9994163ab1f3823b84e7ee610de0cffc54e 100644 --- a/components/finsh/finsh_token.c +++ b/components/finsh/finsh_token.c @@ -66,12 +66,12 @@ static long token_spec_number(char* string, int length, int b); static void token_run(struct finsh_token* self); static int token_match_name(struct finsh_token* self, const char* str); static void token_proc_number(struct finsh_token* self); -static u_char* token_proc_string(struct finsh_token* self); +static uint8_t* token_proc_string(struct finsh_token* self); static void token_trim_space(struct finsh_token* self); static char token_proc_char(struct finsh_token* self); static int token_proc_escape(struct finsh_token* self); -void finsh_token_init(struct finsh_token* self, u_char* line) +void finsh_token_init(struct finsh_token* self, uint8_t* line) { memset(self, 0, sizeof(struct finsh_token)); @@ -86,12 +86,12 @@ enum finsh_token_type finsh_token_token(struct finsh_token* self) return (enum finsh_token_type)self->current_token; } -void finsh_token_get_token(struct finsh_token* self, u_char* token) +void finsh_token_get_token(struct finsh_token* self, uint8_t* token) { strncpy((char*)token, (char*)self->string, FINSH_NAME_MAX); } -int token_get_string(struct finsh_token* self, u_char* str) +int token_get_string(struct finsh_token* self, uint8_t* str) { unsigned char *p=str; char ch; @@ -382,9 +382,9 @@ static char token_proc_char(struct finsh_token* self) return ch; } -static u_char* token_proc_string(struct finsh_token* self) +static uint8_t* token_proc_string(struct finsh_token* self) { - u_char* p; + uint8_t* p; for ( p = &self->string[0]; p - &(self->string[0]) < FINSH_STRING_MAX; ) { diff --git a/components/finsh/finsh_token.h b/components/finsh/finsh_token.h index 4b84521874240c20cdb1252fd90f1be02a59cbf9..57c002c3fb78d63334c2cb11f1900f03e08fe0f1 100644 --- a/components/finsh/finsh_token.h +++ b/components/finsh/finsh_token.h @@ -74,9 +74,9 @@ enum finsh_token_type #define finsh_token_position(self) (self)->position #define finsh_token_replay(self) (self)->replay = 1 -void finsh_token_init(struct finsh_token* self, u_char* script); +void finsh_token_init(struct finsh_token* self, uint8_t* script); enum finsh_token_type finsh_token_token(struct finsh_token* self); -void finsh_token_get_token(struct finsh_token* self, u_char* token); +void finsh_token_get_token(struct finsh_token* self, uint8_t* token); #endif diff --git a/components/finsh/finsh_var.c b/components/finsh/finsh_var.c index 6d6b9ec931f8571b077fdc4a5f606b6f7869c3fc..86a97559f1ffde6dcc863497e40b677a4697c826 100644 --- a/components/finsh/finsh_var.c +++ b/components/finsh/finsh_var.c @@ -104,7 +104,7 @@ struct finsh_var* finsh_var_lookup(const char* name) } #ifdef RT_USING_HEAP -void finsh_sysvar_append(const char* name, u_char type, void* var_addr) +void finsh_sysvar_append(const char* name, uint8_t type, void* var_addr) { /* create a sysvar */ struct finsh_sysvar_item* item; diff --git a/components/finsh/finsh_var.h b/components/finsh/finsh_var.h index 3d10b9d7e08f4364b5e81819a497e0dd02a9f897..d3b88fa53e32548dd12b001ed46d78df87d04555 100644 --- a/components/finsh/finsh_var.h +++ b/components/finsh/finsh_var.h @@ -39,7 +39,7 @@ struct finsh_var { char name[FINSH_NAME_MAX + 1]; /* the name of variable */ - u_char type; /* the type of variable */ + uint8_t type; /* the type of variable */ /* variable value */ union { diff --git a/components/finsh/finsh_vm.c b/components/finsh/finsh_vm.c index 8ed6179273ede824470a05b38db3b98785467b4f..49b1a3194b9e2c8e10e819207e507e89222b7220 100644 --- a/components/finsh/finsh_vm.c +++ b/components/finsh/finsh_vm.c @@ -35,10 +35,10 @@ /* stack */ union finsh_value finsh_vm_stack[FINSH_STACK_MAX]; /* text segment */ -u_char text_segment[FINSH_TEXT_MAX]; +uint8_t text_segment[FINSH_TEXT_MAX]; union finsh_value* finsh_sp; /* stack pointer */ -u_char* finsh_pc; /* PC */ +uint8_t* finsh_pc; /* PC */ /* syscall list, for dynamic system call register */ struct finsh_syscall_item* global_syscall_list = NULL; @@ -46,7 +46,7 @@ struct finsh_syscall_item* global_syscall_list = NULL; // #define FINSH_VM_DISASSEMBLE void finsh_vm_run() { - u_char op; + uint8_t op; /* if you want to disassemble the byte code, please define FINSH_VM_DISASSEMBLE */ #ifdef FINSH_VM_DISASSEMBLE @@ -148,7 +148,7 @@ struct finsh_syscall* finsh_syscall_lookup(const char* name) #ifdef FINSH_VM_DISASSEMBLE void finsh_disassemble() { - u_char *pc, op; + uint8_t *pc, op; pc = &text_segment[0]; while (*pc != 0) diff --git a/components/finsh/finsh_vm.h b/components/finsh/finsh_vm.h index 6291ea9cc755a51d6b39a8043264b02c2061b371..2401f7fe4ab74799bedb0af10ec1a4d5964f98dd 100644 --- a/components/finsh/finsh_vm.h +++ b/components/finsh/finsh_vm.h @@ -41,12 +41,12 @@ union finsh_value { }; extern union finsh_value* finsh_sp; /* stack pointer */ -extern u_char* finsh_pc; /* PC */ +extern uint8_t* finsh_pc; /* PC */ /* stack */ extern union finsh_value finsh_vm_stack[FINSH_STACK_MAX]; /* text segment */ -extern u_char text_segment[FINSH_TEXT_MAX]; +extern uint8_t text_segment[FINSH_TEXT_MAX]; void finsh_vm_run(void); //void finsh_disassemble(void); diff --git a/components/finsh/shell.c b/components/finsh/shell.c index 2d157be3bd827f1db7a6d6c82cb23a2dc219609a..3a1b66fd3f605d88d12accef45b4c42c3eca462c 100644 --- a/components/finsh/shell.c +++ b/components/finsh/shell.c @@ -82,6 +82,23 @@ const char *finsh_get_prompt() } #endif +static char finsh_getchar(void) +{ + RT_ASSERT(shell != RT_NULL); + +#ifdef RT_USING_DFS + return getchar(); +#else + char ch; + + while (rt_device_read(shell->device, -1, &ch, 1) != 1) + rt_sem_take(&shell->rx_sem, RT_WAITING_FOREVER); + + return ch; +#endif +} + +#ifndef RT_USING_DFS static rt_err_t finsh_rx_ind(rt_device_t dev, rt_size_t size) { RT_ASSERT(shell != RT_NULL); @@ -145,6 +162,7 @@ const char *finsh_get_device() RT_ASSERT(shell != RT_NULL); return shell->device->parent.name; } +#endif /** * @ingroup finsh @@ -219,15 +237,14 @@ static void finsh_wait_auth(void) while (1) { - rt_kprintf("Password for finsh: "); + rt_kprintf("Password for login: "); while (!input_finish) { - /* wait receive */ - if (rt_sem_take(&shell->rx_sem, RT_WAITING_FOREVER) != RT_EOK) continue; - - /* read one character from device */ - while (rt_device_read(shell->device, 0, &ch, 1) == 1) + while (1) { + /* read one character from device */ + ch = finsh_getchar(); + if (ch >= ' ' && ch <= '~' && cur_pos < FINSH_PASSWORD_MAX) { /* change the printable characters to '*' */ @@ -258,8 +275,6 @@ static void finsh_wait_auth(void) cur_pos = 0; input_finish = RT_FALSE; rt_memset(password, '\0', FINSH_PASSWORD_MAX); - /* read all last dirty data */ - while (rt_device_read(shell->device, 0, &ch, 1) == 1); } } } @@ -397,18 +412,17 @@ void finsh_thread_entry(void *parameter) finsh_init(&shell->parser); #endif +#ifndef RT_USING_DFS /* set console device as shell device */ if (shell->device == RT_NULL) { -#ifdef RT_USING_CONSOLE - shell->device = rt_console_get_device(); - RT_ASSERT(shell->device); - rt_device_set_rx_indicate(shell->device, finsh_rx_ind); - rt_device_open(shell->device, (RT_DEVICE_OFLAG_RDWR | RT_DEVICE_FLAG_STREAM | RT_DEVICE_FLAG_INT_RX)); -#else - RT_ASSERT(shell->device); -#endif + rt_device_t console = rt_console_get_device(); + if (console) + { + finsh_set_device(console->parent.name); + } } +#endif #ifdef FINSH_USING_AUTH /* set the default password when the password isn't setting */ @@ -427,235 +441,219 @@ void finsh_thread_entry(void *parameter) while (1) { - /* wait receive */ - if (rt_sem_take(&shell->rx_sem, RT_WAITING_FOREVER) != RT_EOK) continue; - - /* read one character from device */ - while (rt_device_read(shell->device, 0, &ch, 1) == 1) + ch = finsh_getchar(); + + /* + * handle control key + * up key : 0x1b 0x5b 0x41 + * down key: 0x1b 0x5b 0x42 + * right key:0x1b 0x5b 0x43 + * left key: 0x1b 0x5b 0x44 + */ + if (ch == 0x1b) + { + shell->stat = WAIT_SPEC_KEY; + continue; + } + else if (shell->stat == WAIT_SPEC_KEY) { - /* - * handle control key - * up key : 0x1b 0x5b 0x41 - * down key: 0x1b 0x5b 0x42 - * right key:0x1b 0x5b 0x43 - * left key: 0x1b 0x5b 0x44 - */ - if (ch == 0x1b) + if (ch == 0x5b) { - shell->stat = WAIT_SPEC_KEY; + shell->stat = WAIT_FUNC_KEY; continue; } - else if (shell->stat == WAIT_SPEC_KEY) + + shell->stat = WAIT_NORMAL; + } + else if (shell->stat == WAIT_FUNC_KEY) + { + shell->stat = WAIT_NORMAL; + + if (ch == 0x41) /* up key */ { - if (ch == 0x5b) +#ifdef FINSH_USING_HISTORY + /* prev history */ + if (shell->current_history > 0) + shell->current_history --; + else { - shell->stat = WAIT_FUNC_KEY; + shell->current_history = 0; continue; } - shell->stat = WAIT_NORMAL; + /* copy the history command */ + memcpy(shell->line, &shell->cmd_history[shell->current_history][0], + FINSH_CMD_SIZE); + shell->line_curpos = shell->line_position = strlen(shell->line); + shell_handle_history(shell); +#endif + continue; } - else if (shell->stat == WAIT_FUNC_KEY) + else if (ch == 0x42) /* down key */ { - shell->stat = WAIT_NORMAL; - - if (ch == 0x41) /* up key */ - { #ifdef FINSH_USING_HISTORY - /* prev history */ - if (shell->current_history > 0) - shell->current_history --; - else - { - shell->current_history = 0; - continue; - } - - /* copy the history command */ - memcpy(shell->line, &shell->cmd_history[shell->current_history][0], - FINSH_CMD_SIZE); - shell->line_curpos = shell->line_position = strlen(shell->line); - shell_handle_history(shell); -#endif - continue; - } - else if (ch == 0x42) /* down key */ + /* next history */ + if (shell->current_history < shell->history_count - 1) + shell->current_history ++; + else { -#ifdef FINSH_USING_HISTORY - /* next history */ - if (shell->current_history < shell->history_count - 1) - shell->current_history ++; + /* set to the end of history */ + if (shell->history_count != 0) + shell->current_history = shell->history_count - 1; else - { - /* set to the end of history */ - if (shell->history_count != 0) - shell->current_history = shell->history_count - 1; - else - continue; - } - - memcpy(shell->line, &shell->cmd_history[shell->current_history][0], - FINSH_CMD_SIZE); - shell->line_curpos = shell->line_position = strlen(shell->line); - shell_handle_history(shell); -#endif - continue; - } - else if (ch == 0x44) /* left key */ - { - if (shell->line_curpos) - { - rt_kprintf("\b"); - shell->line_curpos --; - } - - continue; - } - else if (ch == 0x43) /* right key */ - { - if (shell->line_curpos < shell->line_position) - { - rt_kprintf("%c", shell->line[shell->line_curpos]); - shell->line_curpos ++; - } - - continue; + continue; } + memcpy(shell->line, &shell->cmd_history[shell->current_history][0], + FINSH_CMD_SIZE); + shell->line_curpos = shell->line_position = strlen(shell->line); + shell_handle_history(shell); +#endif + continue; } - - /* handle CR key */ - if (ch == '\r') + else if (ch == 0x44) /* left key */ { - char next; - - if (rt_device_read(shell->device, 0, &next, 1) == 1) + if (shell->line_curpos) { - if (next == '\0') ch = '\r'; /* linux telnet will issue '\0' */ - else ch = next; - } - else ch = '\r'; - } - /* handle tab key */ - else if (ch == '\t') - { - int i; - /* move the cursor to the beginning of line */ - for (i = 0; i < shell->line_curpos; i++) rt_kprintf("\b"); - - /* auto complete */ - shell_auto_complete(&shell->line[0]); - /* re-calculate position */ - shell->line_curpos = shell->line_position = strlen(shell->line); + shell->line_curpos --; + } continue; } - /* handle backspace key */ - else if (ch == 0x7f || ch == 0x08) + else if (ch == 0x43) /* right key */ { - /* note that shell->line_curpos >= 0 */ - if (shell->line_curpos == 0) - continue; - - shell->line_position--; - shell->line_curpos--; - - if (shell->line_position > shell->line_curpos) - { - int i; - - rt_memmove(&shell->line[shell->line_curpos], - &shell->line[shell->line_curpos + 1], - shell->line_position - shell->line_curpos); - shell->line[shell->line_position] = 0; - - rt_kprintf("\b%s \b", &shell->line[shell->line_curpos]); - - /* move the cursor to the origin position */ - for (i = shell->line_curpos; i <= shell->line_position; i++) - rt_kprintf("\b"); - } - else + if (shell->line_curpos < shell->line_position) { - rt_kprintf("\b \b"); - shell->line[shell->line_position] = 0; + rt_kprintf("%c", shell->line[shell->line_curpos]); + shell->line_curpos ++; } continue; } + } - /* handle end of line, break */ - if (ch == '\r' || ch == '\n') - { -#ifdef FINSH_USING_HISTORY - shell_push_history(shell); -#endif - -#ifdef FINSH_USING_MSH - if (msh_is_used() == RT_TRUE) - { - if (shell->echo_mode) - rt_kprintf("\n"); - msh_exec(shell->line, shell->line_position); - } - else -#endif - { -#ifndef FINSH_USING_MSH_ONLY - /* add ';' and run the command line */ - shell->line[shell->line_position] = ';'; + /* handle CR key */ + if (ch == '\0') continue; + /* handle tab key */ + else if (ch == '\t') + { + int i; + /* move the cursor to the beginning of line */ + for (i = 0; i < shell->line_curpos; i++) + rt_kprintf("\b"); - if (shell->line_position != 0) finsh_run_line(&shell->parser, shell->line); - else - if (shell->echo_mode) rt_kprintf("\n"); -#endif - } + /* auto complete */ + shell_auto_complete(&shell->line[0]); + /* re-calculate position */ + shell->line_curpos = shell->line_position = strlen(shell->line); - rt_kprintf(FINSH_PROMPT); - memset(shell->line, 0, sizeof(shell->line)); - shell->line_curpos = shell->line_position = 0; - break; - } + continue; + } + /* handle backspace key */ + else if (ch == 0x7f || ch == 0x08) + { + /* note that shell->line_curpos >= 0 */ + if (shell->line_curpos == 0) + continue; - /* it's a large line, discard it */ - if (shell->line_position >= FINSH_CMD_SIZE) - shell->line_position = 0; + shell->line_position--; + shell->line_curpos--; - /* normal character */ - if (shell->line_curpos < shell->line_position) + if (shell->line_position > shell->line_curpos) { int i; - rt_memmove(&shell->line[shell->line_curpos + 1], - &shell->line[shell->line_curpos], + rt_memmove(&shell->line[shell->line_curpos], + &shell->line[shell->line_curpos + 1], shell->line_position - shell->line_curpos); - shell->line[shell->line_curpos] = ch; - if (shell->echo_mode) - rt_kprintf("%s", &shell->line[shell->line_curpos]); + shell->line[shell->line_position] = 0; + + rt_kprintf("\b%s \b", &shell->line[shell->line_curpos]); - /* move the cursor to new position */ - for (i = shell->line_curpos; i < shell->line_position; i++) + /* move the cursor to the origin position */ + for (i = shell->line_curpos; i <= shell->line_position; i++) rt_kprintf("\b"); } else { - shell->line[shell->line_position] = ch; - if (shell->echo_mode) - rt_kprintf("%c", ch); + rt_kprintf("\b \b"); + shell->line[shell->line_position] = 0; } - ch = 0; - shell->line_position ++; - shell->line_curpos++; - if (shell->line_position >= FINSH_CMD_SIZE) + continue; + } + + /* handle end of line, break */ + if (ch == '\r' || ch == '\n') + { +#ifdef FINSH_USING_HISTORY + shell_push_history(shell); +#endif + +#ifdef FINSH_USING_MSH + if (msh_is_used() == RT_TRUE) { - /* clear command line */ - shell->line_position = 0; - shell->line_curpos = 0; + if (shell->echo_mode) + rt_kprintf("\n"); + msh_exec(shell->line, shell->line_position); } - } /* end of device read */ - } + else +#endif + { +#ifndef FINSH_USING_MSH_ONLY + /* add ';' and run the command line */ + shell->line[shell->line_position] = ';'; + + if (shell->line_position != 0) finsh_run_line(&shell->parser, shell->line); + else + if (shell->echo_mode) rt_kprintf("\n"); +#endif + } + + rt_kprintf(FINSH_PROMPT); + memset(shell->line, 0, sizeof(shell->line)); + shell->line_curpos = shell->line_position = 0; + continue; + } + + /* it's a large line, discard it */ + if (shell->line_position >= FINSH_CMD_SIZE) + shell->line_position = 0; + + /* normal character */ + if (shell->line_curpos < shell->line_position) + { + int i; + + rt_memmove(&shell->line[shell->line_curpos + 1], + &shell->line[shell->line_curpos], + shell->line_position - shell->line_curpos); + shell->line[shell->line_curpos] = ch; + if (shell->echo_mode) + rt_kprintf("%s", &shell->line[shell->line_curpos]); + + /* move the cursor to new position */ + for (i = shell->line_curpos; i < shell->line_position; i++) + rt_kprintf("\b"); + } + else + { + shell->line[shell->line_position] = ch; + if (shell->echo_mode) + rt_kprintf("%c", ch); + } + + ch = 0; + shell->line_position ++; + shell->line_curpos++; + if (shell->line_position >= FINSH_CMD_SIZE) + { + /* clear command line */ + shell->line_position = 0; + shell->line_curpos = 0; + } + } /* end of device read */ } void finsh_system_function_init(const void *begin, const void *end) @@ -779,5 +777,5 @@ int finsh_system_init(void) rt_thread_startup(&finsh_thread); return 0; } -INIT_COMPONENT_EXPORT(finsh_system_init); +INIT_APP_EXPORT(finsh_system_init); diff --git a/components/finsh/shell.h b/components/finsh/shell.h index a4c96b9a26468602f42958d422a07c03509ffb64..71bda9809cc8f69f7df275ab1c3c3e3fb830da5c 100644 --- a/components/finsh/shell.h +++ b/components/finsh/shell.h @@ -33,15 +33,8 @@ #include #include "finsh.h" -/* For historical reasons, users don't define FINSH_USING_HISTORY in rtconfig.h - * but expect the history feature. So you sould define FINSH_USING_HISTORY to 0 - * to disable it from the rtconfig.h. */ -#ifdef FINSH_USING_HISTORY -# if FINSH_USING_HISTORY == 0 -# undef FINSH_USING_HISTORY -# endif -#else -# define FINSH_USING_HISTORY +#ifndef FINSH_USING_HISTORY +#define FINSH_USING_HISTORY #endif #ifndef FINSH_THREAD_PRIORITY @@ -109,7 +102,9 @@ struct finsh_shell rt_uint8_t line_position; rt_uint8_t line_curpos; +#ifndef RT_USING_DFS rt_device_t device; +#endif #ifdef FINSH_USING_AUTH char password[FINSH_PASSWORD_MAX];