From ee00c5fa8bda9b468dcfd072be3c98b208c8bcd5 Mon Sep 17 00:00:00 2001
From: zhangle <zhanglea@ctrip.com>
Date: Wed, 31 Aug 2016 17:09:25 +0800
Subject: [PATCH] history page use release id as anchor

---
 .../src/main/resources/static/config/history.html     |  4 ++--
 .../scripts/directive/namespace-panel-directive.js    |  6 +++---
 .../static/views/component/namespace-panel.html       | 11 ++++++-----
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/apollo-portal/src/main/resources/static/config/history.html b/apollo-portal/src/main/resources/static/config/history.html
index b91a5256c..e91fe6ae8 100644
--- a/apollo-portal/src/main/resources/static/config/history.html
+++ b/apollo-portal/src/main/resources/static/config/history.html
@@ -37,7 +37,7 @@
                         <span class="label label-primary no-radius"
                               ng-if="release.active">当前生效</span>
                     </div>
-                    <div class="row" id="{{release.baseInfo.name}}">
+                    <div class="row" id="{{release.baseInfo.id}}">
                         <div class="col-md-2 user">
                             <img src="../img/user.png" class="i-20">
                             <span class="info" ng-bind="release.baseInfo.dataChangeCreatedBy"></span>
@@ -50,7 +50,7 @@
                         <div class="col-md-3 time">
                             <img src="../img/title.png" class="i-20">
                         <span class="info"
-                              ng-bind="release.baseInfo.name" ng-class="{'highlight':pageContext.scrollTo == release.baseInfo.name}"></span>
+                              ng-bind="release.baseInfo.name" ng-class="{'highlight':pageContext.scrollTo == release.baseInfo.id}"></span>
 
                         </div>
                         <div class="col-md-4 comment" ng-show="release.baseInfo.comment">
diff --git a/apollo-portal/src/main/resources/static/scripts/directive/namespace-panel-directive.js b/apollo-portal/src/main/resources/static/scripts/directive/namespace-panel-directive.js
index 0630671c9..e847ba01a 100644
--- a/apollo-portal/src/main/resources/static/scripts/directive/namespace-panel-directive.js
+++ b/apollo-portal/src/main/resources/static/scripts/directive/namespace-panel-directive.js
@@ -246,7 +246,7 @@ directive_module.directive('apollonspanel',
                                                        }
 
                                                        var groupedInstances = {},
-                                                           notLatestReleaseNames = [];
+                                                           notLatestReleases = [];
 
                                                        result.forEach(function (instance) {
                                                            var configs = instance.configs;
@@ -255,14 +255,14 @@ directive_module.directive('apollonspanel',
                                                                    var release = instanceConfig.release;
                                                                    if (!groupedInstances[release.name]) {
                                                                        groupedInstances[release.name] = [];
-                                                                       notLatestReleaseNames.push(release.name);
+                                                                       notLatestReleases.push(release);
                                                                    }
                                                                    groupedInstances[release.name].push(instance);
                                                                })
                                                            }
                                                        });
 
-                                                       namespace.notLatestReleaseNames = notLatestReleaseNames;
+                                                       namespace.notLatestReleases = notLatestReleases;
                                                        namespace.notLatestReleaseInstances = groupedInstances;
                                                    })
 
diff --git a/apollo-portal/src/main/resources/static/views/component/namespace-panel.html b/apollo-portal/src/main/resources/static/views/component/namespace-panel.html
index 0d923bc4d..64f26de94 100644
--- a/apollo-portal/src/main/resources/static/views/component/namespace-panel.html
+++ b/apollo-portal/src/main/resources/static/views/component/namespace-panel.html
@@ -375,7 +375,7 @@
             <div class="panel-default" ng-if="namespace.latestReleaseInstances.total > 0">
                 <div class="panel-heading">
                     <a target="_blank" data-tooltip="tooltip" data-placement="bottom" title="查看配置"
-                       href="/config/history.html?#/appid={{appId}}&env={{env}}&clusterName={{cluster}}&namespaceName={{namespace.baseInfo.namespaceName}}&scrollTo={{namespace.latestRelease.name}}">
+                       href="/config/history.html?#/appid={{appId}}&env={{env}}&clusterName={{cluster}}&namespaceName={{namespace.baseInfo.namespaceName}}&scrollTo={{namespace.latestRelease.id}}">
                         {{namespace.latestRelease.name}}
                     </a>
                 </div>
@@ -410,11 +410,12 @@
 
         <!--not latest release instances-->
         <div class="panel-body" ng-show="namespace.instanceViewType == 'not_latest_release'">
-            <div class="panel-default" ng-if="namespace.instancesCount - namespace.latestReleaseInstances.total > 0" ng-repeat="releaseName in namespace.notLatestReleaseNames">
+            <div class="panel-default" ng-if="namespace.instancesCount - namespace.latestReleaseInstances.total > 0"
+                 ng-repeat="release in namespace.notLatestReleases">
                 <div class="panel-heading">
                     <a target="_blank" data-tooltip="tooltip" data-placement="bottom" title="查看配置"
-                       href="/config/history.html?#/appid={{appId}}&env={{env}}&clusterName={{cluster}}&namespaceName={{namespace.baseInfo.namespaceName}}&scrollTo={{releaseName}}">
-                        {{releaseName}}
+                       href="/config/history.html?#/appid={{appId}}&env={{env}}&clusterName={{cluster}}&namespaceName={{namespace.baseInfo.namespaceName}}&scrollTo={{release.id}}">
+                        {{release.name}}
                     </a>
 
                 </div>
@@ -428,7 +429,7 @@
                     </tr>
                     </thead>
                     <tbody>
-                    <tr ng-repeat="instance in namespace.notLatestReleaseInstances[releaseName]">
+                    <tr ng-repeat="instance in namespace.notLatestReleaseInstances[release.name]">
                         <td width="25%" ng-bind="instance.appId"></td>
                         <td width="25%" ng-bind="instance.clusterName"></td>
                         <td width="25%" ng-bind="instance.dataCenter"></td>
-- 
GitLab