From e4d3ba56f21f7aea122019eae1456ba963653b29 Mon Sep 17 00:00:00 2001
From: lepdou <ledou.zhang@dianping.com>
Date: Wed, 20 Apr 2016 15:51:40 +0800
Subject: [PATCH] item lastModifiedBy

---
 .../controller/ItemController.java            | 11 ++++++++-
 .../ctrip/apollo/biz/entity/BaseEntity.java   |  1 +
 .../apollo/biz/service/ItemSetService.java    |  1 -
 .../com/ctrip/apollo/core/dto/ItemDTO.java    | 23 +++++++++++++++++++
 .../src/main/resources/static/views/app.html  |  4 ++--
 5 files changed, 36 insertions(+), 4 deletions(-)

diff --git a/apollo-adminservice/src/main/java/com/ctrip/apollo/adminservice/controller/ItemController.java b/apollo-adminservice/src/main/java/com/ctrip/apollo/adminservice/controller/ItemController.java
index 73271a907..726267098 100644
--- a/apollo-adminservice/src/main/java/com/ctrip/apollo/adminservice/controller/ItemController.java
+++ b/apollo-adminservice/src/main/java/com/ctrip/apollo/adminservice/controller/ItemController.java
@@ -1,5 +1,6 @@
 package com.ctrip.apollo.adminservice.controller;
 
+import java.util.LinkedList;
 import java.util.List;
 
 import org.springframework.beans.factory.annotation.Autowired;
@@ -59,7 +60,15 @@ public class ItemController {
       @PathVariable("clusterName") String clusterName,
       @PathVariable("namespaceName") String namespaceName) {
     List<Item> items = viewService.findItems(appId, clusterName, namespaceName);
-    return BeanUtils.batchTransform(ItemDTO.class, items);
+    List<ItemDTO> itemDTOs = new LinkedList<>();
+
+    for (Item item: items){
+      ItemDTO itemDTO = BeanUtils.transfrom(ItemDTO.class, item);
+      itemDTO.setLastModifiedBy(item.getDataChangeLastModifiedBy());
+      itemDTO.setLastModifiedTime(item.getDataChangeLastModifiedTime());
+      itemDTOs.add(itemDTO);
+    }
+    return itemDTOs;
   }
 
   @RequestMapping("/items/{itemId}")
diff --git a/apollo-biz/src/main/java/com/ctrip/apollo/biz/entity/BaseEntity.java b/apollo-biz/src/main/java/com/ctrip/apollo/biz/entity/BaseEntity.java
index 1a47b3708..40918416b 100644
--- a/apollo-biz/src/main/java/com/ctrip/apollo/biz/entity/BaseEntity.java
+++ b/apollo-biz/src/main/java/com/ctrip/apollo/biz/entity/BaseEntity.java
@@ -90,6 +90,7 @@ public abstract class BaseEntity {
   @PrePersist
   protected void prePersist() {
     if (this.dataChangeCreatedTime == null) dataChangeCreatedTime = new Date();
+    if (this.dataChangeLastModifiedTime == null) dataChangeLastModifiedTime = new Date();
   }
 
   @PreUpdate
diff --git a/apollo-biz/src/main/java/com/ctrip/apollo/biz/service/ItemSetService.java b/apollo-biz/src/main/java/com/ctrip/apollo/biz/service/ItemSetService.java
index f6013123f..713979475 100644
--- a/apollo-biz/src/main/java/com/ctrip/apollo/biz/service/ItemSetService.java
+++ b/apollo-biz/src/main/java/com/ctrip/apollo/biz/service/ItemSetService.java
@@ -27,7 +27,6 @@ public class ItemSetService {
     if (changeSet.getCreateItems() != null) {
       for (ItemDTO item : changeSet.getCreateItems()) {
         Item entity = BeanUtils.transfrom(Item.class, item);
-        entity.setDataChangeCreatedTime(new Date());
         entity.setDataChangeCreatedBy(owner);
         entity.setDataChangeLastModifiedBy(owner);
         itemRepository.save(entity);
diff --git a/apollo-core/src/main/java/com/ctrip/apollo/core/dto/ItemDTO.java b/apollo-core/src/main/java/com/ctrip/apollo/core/dto/ItemDTO.java
index 66aafa584..8ebe0feae 100644
--- a/apollo-core/src/main/java/com/ctrip/apollo/core/dto/ItemDTO.java
+++ b/apollo-core/src/main/java/com/ctrip/apollo/core/dto/ItemDTO.java
@@ -1,5 +1,7 @@
 package com.ctrip.apollo.core.dto;
 
+import java.util.Date;
+
 public class ItemDTO {
 
   private long id;
@@ -14,6 +16,10 @@ public class ItemDTO {
 
   private int lineNum;
 
+  private String lastModifiedBy;
+
+  private Date lastModifiedTime;
+
   public ItemDTO() {
 
   }
@@ -73,6 +79,21 @@ public class ItemDTO {
     this.lineNum = lineNum;
   }
 
+  public String getLastModifiedBy() {
+    return lastModifiedBy;
+  }
+
+  public void setLastModifiedBy(String lastModifiedBy) {
+    this.lastModifiedBy = lastModifiedBy;
+  }
+
+  public Date getLastModifiedTime() {
+    return lastModifiedTime;
+  }
+
+  public void setLastModifiedTime(Date lastModifiedTime) {
+    this.lastModifiedTime = lastModifiedTime;
+  }
 
   @Override
   public String toString() {
@@ -83,6 +104,8 @@ public class ItemDTO {
            ", value='" + value + '\'' +
            ", comment='" + comment + '\'' +
            ", lineNum=" + lineNum +
+           ", lastModifiedBy='" + lastModifiedBy + '\'' +
+           ", lastModifiedTime=" + lastModifiedTime +
            '}';
   }
 }
diff --git a/apollo-portal/src/main/resources/static/views/app.html b/apollo-portal/src/main/resources/static/views/app.html
index 19add7be3..99cd4a019 100644
--- a/apollo-portal/src/main/resources/static/views/app.html
+++ b/apollo-portal/src/main/resources/static/views/app.html
@@ -148,10 +148,10 @@
                                             {{config.item.comment}}
                                         </td>
                                         <td>
-                                            {{config.item.dataChangeLastModifiedBy}}
+                                            {{config.item.lastModifiedBy}}
                                         </td>
                                         <td>
-                                            {{config.item.dataChangeLastModifiedTime | date: 'yyyy-MM-dd HH:mm:ss'}}
+                                            {{config.item.lastModifiedTime | date: 'yyyy-MM-dd HH:mm:ss'}}
                                         </td>
 
                                     </tr>
-- 
GitLab