From dc38354f6f3bedab224d97c0084b997a5bdf498f Mon Sep 17 00:00:00 2001
From: Jason Song <nobodyiam@gmail.com>
Date: Thu, 20 Apr 2017 13:34:51 +0800
Subject: [PATCH] fix coverity bug

---
 .../internals/NetworkInterfaceManager.java        | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/apollo-core/src/main/java/com/ctrip/framework/foundation/internals/NetworkInterfaceManager.java b/apollo-core/src/main/java/com/ctrip/framework/foundation/internals/NetworkInterfaceManager.java
index 2581c1e1e..66c0d3678 100644
--- a/apollo-core/src/main/java/com/ctrip/framework/foundation/internals/NetworkInterfaceManager.java
+++ b/apollo-core/src/main/java/com/ctrip/framework/foundation/internals/NetworkInterfaceManager.java
@@ -98,8 +98,12 @@ public enum NetworkInterfaceManager {
 
     try {
       Enumeration<NetworkInterface> interfaces = NetworkInterface.getNetworkInterfaces();
-      List<NetworkInterface> nis = interfaces == null ? Collections.<NetworkInterface>emptyList()
-          : Collections.list(NetworkInterface.getNetworkInterfaces());
+      List<NetworkInterface> nis;
+      if (interfaces == null) {
+        nis = Collections.emptyList();
+      } else {
+        nis = Collections.list(NetworkInterface.getNetworkInterfaces());
+      }
       List<InetAddress> addresses = new ArrayList<InetAddress>();
       InetAddress local = null;
 
@@ -113,9 +117,14 @@ public enum NetworkInterfaceManager {
       } catch (Exception e) {
         // ignore
       }
-      m_local = local;
+      if (local != null) {
+        m_local = local;
+        return;
+      }
     } catch (SocketException e) {
       // ignore it
     }
+
+    m_local = InetAddress.getLoopbackAddress();
   }
 }
-- 
GitLab