From 16986c3c651af38469c6d4cb03a587fd174c9a9b Mon Sep 17 00:00:00 2001
From: Wenjun Ruan <861923274@qq.com>
Date: Sun, 11 Jul 2021 00:31:45 +0800
Subject: [PATCH] [Imporvement #5725][CheckStyle] upgrade checkstyle file
 (#5789)

* [Imporvement #5725][CheckStyle] upgrade checkstyle file
  Upgrade checkstyle.xml to support checkstyle version 8.24+

* change ci checkstyle version
---
 .github/workflows/ci_ut.yml |  2 +-
 style/checkstyle.xml        | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/ci_ut.yml b/.github/workflows/ci_ut.yml
index 54ce79c6e..f7f6e1cf5 100644
--- a/.github/workflows/ci_ut.yml
+++ b/.github/workflows/ci_ut.yml
@@ -108,7 +108,7 @@ jobs:
           CHECKSTYLE_CONFIG: style/checkstyle.xml
           REVIEWDOG_VERSION: v0.10.2
         run: |
-          wget -O - -q https://github.com/checkstyle/checkstyle/releases/download/checkstyle-8.22/checkstyle-8.22-all.jar > /opt/checkstyle.jar
+          wget -O - -q https://github.com/checkstyle/checkstyle/releases/download/checkstyle-8.43/checkstyle-8.43-all.jar > /opt/checkstyle.jar
           wget -O - -q https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b /opt ${REVIEWDOG_VERSION}
           java -jar /opt/checkstyle.jar "${WORKDIR}" -c "${CHECKSTYLE_CONFIG}"  -f xml \
                | /opt/reviewdog -f=checkstyle \
diff --git a/style/checkstyle.xml b/style/checkstyle.xml
index 675d82133..2dba3b9a7 100644
--- a/style/checkstyle.xml
+++ b/style/checkstyle.xml
@@ -34,6 +34,11 @@
         <property name="optional" value="true"/>
     </module>
 
+    <module name="LineLength">
+        <property name="max" value="200"/>
+        <property name="ignorePattern" value="^ *\* *[^ ]+$"/>
+    </module>
+
     <module name="TreeWalker">
         <module name="OuterTypeFilename">
             <property name="severity" value="error"/>
@@ -73,11 +78,6 @@
             <property name="allowNonPrintableEscapes" value="true"/>
         </module>
 
-        <module name="LineLength">
-            <property name="max" value="200"/>
-            <property name="ignorePattern" value="^ *\* *[^ ]+$"/>
-        </module>
-
         <module name="EmptyBlock">
             <property name="option" value="TEXT"/>
             <property name="tokens" value="LITERAL_TRY, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
-- 
GitLab