From b36d028260411c1370f8ac1906210122de86d310 Mon Sep 17 00:00:00 2001 From: Christoph Kutzinski Date: Sun, 17 Jul 2011 11:56:36 +0200 Subject: [PATCH] prevent string concatenation if log level is coarser than FINE --- core/src/main/java/hudson/tasks/junit/XMLEntityResolver.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/tasks/junit/XMLEntityResolver.java b/core/src/main/java/hudson/tasks/junit/XMLEntityResolver.java index 823c02a219..1a5c934b18 100644 --- a/core/src/main/java/hudson/tasks/junit/XMLEntityResolver.java +++ b/core/src/main/java/hudson/tasks/junit/XMLEntityResolver.java @@ -33,6 +33,7 @@ import org.xml.sax.SAXException; import java.io.IOException; import java.net.URL; +import java.util.logging.Level; import java.util.logging.Logger; /** @@ -57,7 +58,9 @@ public class XMLEntityResolver extends ParserConfigurator implements EntityResol */ public InputSource resolveEntity(String publicId, String systemId) throws SAXException, IOException { if (systemId != null) { - LOGGER.fine("Will try to resolve systemId [" + systemId + "]"); + if (LOGGER.isLoggable(Level.FINE)) { + LOGGER.fine("Will try to resolve systemId [" + systemId + "]"); + } // TestNG system-ids if (systemId.startsWith(TESTNG_NAMESPACE)) { LOGGER.fine("It's a TestNG document, will try to lookup DTD in classpath"); -- GitLab