From 0ccc076b405f904c740db39c6f0ba1219a4c2fb5 Mon Sep 17 00:00:00 2001 From: Christoph Kutzinski Date: Sun, 24 Jul 2011 10:38:52 +0200 Subject: [PATCH] fixed some compiler warnings --- core/src/test/java/hudson/BulkChangeTest.java | 1 + core/src/test/java/hudson/FilePathTest.java | 7 +++---- core/src/test/java/hudson/LauncherTest.java | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/core/src/test/java/hudson/BulkChangeTest.java b/core/src/test/java/hudson/BulkChangeTest.java index d7802fb8a0..449e28d2fc 100644 --- a/core/src/test/java/hudson/BulkChangeTest.java +++ b/core/src/test/java/hudson/BulkChangeTest.java @@ -41,6 +41,7 @@ public class BulkChangeTest extends TestCase { */ int saveCount = 0; + @SuppressWarnings("unused") int x,y; public void setX(int x) throws IOException { diff --git a/core/src/test/java/hudson/FilePathTest.java b/core/src/test/java/hudson/FilePathTest.java index 26aeab23cb..c91ce89978 100644 --- a/core/src/test/java/hudson/FilePathTest.java +++ b/core/src/test/java/hudson/FilePathTest.java @@ -23,7 +23,6 @@ */ package hudson; -import hudson.remoting.Future; import hudson.remoting.VirtualChannel; import hudson.util.IOException2; import hudson.util.NullStream; @@ -102,7 +101,7 @@ public class FilePathTest extends ChannelTestCase { ExecutorService es = Executors.newFixedThreadPool(100); try { - List r = new ArrayList(); + List> r = new ArrayList>(); for (int i=0; i<100; i++) { r.add(es.submit(new Callable() { public Object call() throws Exception { @@ -150,7 +149,7 @@ public class FilePathTest extends ChannelTestCase { })); } - for (java.util.concurrent.Future f : r) + for (java.util.concurrent.Future f : r) f.get(); } finally { es.shutdown(); @@ -166,7 +165,7 @@ public class FilePathTest extends ChannelTestCase { try { assertTrue(src.mkdir()); assertTrue(dst.mkdir()); - File f = File.createTempFile("foo", ".tmp", src); + File.createTempFile("foo", ".tmp", src); FilePath fp = new FilePath(src); assertEquals(1, fp.copyRecursiveTo(new FilePath(dst))); // copy again should still report 1 diff --git a/core/src/test/java/hudson/LauncherTest.java b/core/src/test/java/hudson/LauncherTest.java index 07d20a4b08..b3a629109f 100644 --- a/core/src/test/java/hudson/LauncherTest.java +++ b/core/src/test/java/hudson/LauncherTest.java @@ -70,8 +70,8 @@ public class LauncherTest extends ChannelTestCase { } } - private static final Callable NOOP = new Callable() { - public Object call() throws Exception { + private static final Callable NOOP = new Callable() { + public Object call() throws RuntimeException { return null; } }; -- GitLab