From 08f2804625522c84dbc54a6208c5686a06858646 Mon Sep 17 00:00:00 2001
From: Kohsuke Kawaguchi <kk@kohsuke.org>
Date: Sat, 14 Apr 2012 07:31:59 -0700
Subject: [PATCH] As was discussed in pull request #421, not caching it.

---
 core/src/main/java/hudson/model/Run.java      | 29 +++++--------------
 .../model/AbstractBuild/sidepanel.jelly       | 10 +------
 2 files changed, 9 insertions(+), 30 deletions(-)

diff --git a/core/src/main/java/hudson/model/Run.java b/core/src/main/java/hudson/model/Run.java
index cf93219af8..b7cc78a2b5 100644
--- a/core/src/main/java/hudson/model/Run.java
+++ b/core/src/main/java/hudson/model/Run.java
@@ -242,8 +242,6 @@ public abstract class Run <JobT extends Job<JobT,RunT>,RunT extends Run<JobT,Run
      * This field is not persisted.
      */
     private volatile transient Runner runner;
-    
-    protected transient List<Action> transientActions;
 
     protected static final ThreadLocal<SimpleDateFormat> ID_FORMATTER =
             new ThreadLocal<SimpleDateFormat>() {
@@ -274,7 +272,6 @@ public abstract class Run <JobT extends Job<JobT,RunT>,RunT extends Run<JobT,Run
         this.timestamp = timestamp;
         this.state = State.NOT_STARTED;
 		getRootDir().mkdirs();
-        transientActions = updateTransientActions();
     }
 
     /**
@@ -307,31 +304,21 @@ public abstract class Run <JobT extends Job<JobT,RunT>,RunT extends Run<JobT,Run
         for (Action a : getActions())
             if (a instanceof RunAction)
                 ((RunAction) a).onLoad();
-        transientActions = updateTransientActions();
     }
     
     /**
-     * Return all transient actions associated with this build
+     * Return all transient actions associated with this build.
      * 
-     * @return transient actions
+     * @return the list can be empty but never null. read only.
      */
-    public List<Action> getTransientActions(){
-        return transientActions;
-    }
-   
-    /**
-     * Create transient actions for this build
-     * 
-     * @return transient actions
-     */
-    public List<Action> updateTransientActions(){
+    public List<Action> getTransientActions() {
         List<Action> actions = new ArrayList<Action>();
-        for(TransientBuildActionFactory factory: TransientBuildActionFactory.all()){
+        for (TransientBuildActionFactory factory: TransientBuildActionFactory.all()) {
             actions.addAll(factory.createFor(this));
         }
-        return actions;
-     }
-
+        return Collections.unmodifiableList(actions);
+    }
+   
     @Override
     public void addAction(Action a) {
         super.addAction(a);
@@ -2087,7 +2074,7 @@ public abstract class Run <JobT extends Job<JobT,RunT>,RunT extends Run<JobT,Run
         Object result = super.getDynamic(token, req, rsp);
         if (result == null){
             //check transient actions too
-            for(Action action: transientActions){
+            for(Action action: getTransientActions()){
                 if(action.getUrlName().equals(token))
                     return action;
             }
diff --git a/core/src/main/resources/hudson/model/AbstractBuild/sidepanel.jelly b/core/src/main/resources/hudson/model/AbstractBuild/sidepanel.jelly
index b7be15fc1e..98fa11f963 100644
--- a/core/src/main/resources/hudson/model/AbstractBuild/sidepanel.jelly
+++ b/core/src/main/resources/hudson/model/AbstractBuild/sidepanel.jelly
@@ -33,15 +33,7 @@ THE SOFTWARE.
       <j:set var="buildUrl" value="${h.decompose(request)}" />
       <st:include page="tasks.jelly"/>
       <st:include page="actions.jelly" />
-      <!-- add transient actions too -->
-      <j:forEach var="action" items="${it.transientActions}">          
-        <st:include page="action.jelly" from="${action}" optional="true">
-            <j:if test="${action.iconFileName!=null}">
-                <l:task icon="${h.getIconFilePath(action)}" title="${action.displayName}"
-                href="${h.getActionUrl(it.url,action)}" />
-            </j:if>
-        </st:include>
-      </j:forEach>
+      <t:actions actions="${it.transientActions}"/>
       <j:if test="${it.previousBuild!=null}">
         <l:task icon="images/24x24/previous.png" href="${buildUrl.previousBuildUrl}" title="${%Previous Build}" contextMenu="false"/>
       </j:if>
-- 
GitLab