提交 0841fd64 编写于 作者: K Kohsuke Kawaguchi

- In modern code we've been exposing DescribableList directly since it's a lot richer.

- calling prebuild after build wrappers to align the semantics with freestyle projects.
上级 cd968ce2
......@@ -60,7 +60,6 @@ import hudson.tasks.BuildStepDescriptor;
import hudson.tasks.BuildWrapper;
import hudson.tasks.BuildWrappers;
import hudson.tasks.Fingerprinter;
import hudson.tasks.JavadocArchiver;
import hudson.tasks.Mailer;
import hudson.tasks.Maven;
import hudson.tasks.Maven.MavenInstallation;
......@@ -281,12 +280,22 @@ public class MavenModuleSet extends AbstractMavenProject<MavenModuleSet,MavenMod
super(parent,name);
}
public List<Builder> getPrebuilders() {
return prebuilders.toList();
/**
* Builders that are run before the main Maven execution.
*
* @since 1.433
*/
public DescribableList<Builder,Descriptor<Builder>> getPrebuilders() {
return prebuilders;
}
public List<Builder> getPostbuilders() {
return postbuilders.toList();
/**
* Builders that are run after the main Maven execution.
*
* @since 1.433
*/
public DescribableList<Builder,Descriptor<Builder>> getPostbuilders() {
return postbuilders;
}
/**
......
......@@ -591,17 +591,6 @@ public class MavenModuleSetBuild extends AbstractMavenBuild<MavenModuleSet,Maven
} else {
// do builds here
try {
// run pre build steps
if(!preBuild(listener,project.getPrebuilders())){
r = FAILURE;
return r;
}
if(!build(listener,project.getPrebuilders())){
r = FAILURE;
return r;
}
List<BuildWrapper> wrappers = new ArrayList<BuildWrapper>();
for (BuildWrapper w : project.getBuildWrappersList())
wrappers.add(w);
......@@ -617,11 +606,20 @@ public class MavenModuleSetBuild extends AbstractMavenBuild<MavenModuleSet,Maven
e.buildEnvVars(envVars); // #3502: too late for getEnvironment to do this
}
// run pre build steps
if(!preBuild(listener,project.getPrebuilders())){
r = FAILURE;
return r;
}
if(!preBuild(listener, project.getPublishers())){
r = FAILURE;
return r;
}
if(!build(listener,project.getPrebuilders().toList())){
r = FAILURE;
return r;
}
String settingsConfigId = project.getSettingConfigId();
if (!StringUtils.isBlank(settingsConfigId)) {
......@@ -805,7 +803,7 @@ public class MavenModuleSetBuild extends AbstractMavenBuild<MavenModuleSet,Maven
proceedPostSteps = false;
}
if(proceedPostSteps){
if(!build(listener,project.getPostbuilders())){
if(!build(listener,project.getPostbuilders().toList())){
r = FAILURE;
}
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册