提交 d2b4d726 编写于 作者: martianzhang's avatar martianzhang

fix ARG.014 swich case add wrong place

上级 0d2d1db6
...@@ -2640,10 +2640,6 @@ func (q *Query4Audit) RuleIn() Rule { ...@@ -2640,10 +2640,6 @@ func (q *Query4Audit) RuleIn() Rule {
// by pass sub query // by pass sub query
// id in (select id from tb where xxx) // id in (select id from tb where xxx)
break break
case sqlparser.ColTuple:
// id in (1, 2, id), always true.
rule = HeuristicRules["ARG.014"]
return false, nil
case sqlparser.ValTuple: case sqlparser.ValTuple:
// IN (NULL) // IN (NULL)
for _, v := range r { for _, v := range r {
...@@ -2651,6 +2647,11 @@ func (q *Query4Audit) RuleIn() Rule { ...@@ -2651,6 +2647,11 @@ func (q *Query4Audit) RuleIn() Rule {
case *sqlparser.NullVal: case *sqlparser.NullVal:
rule = HeuristicRules["ARG.004"] rule = HeuristicRules["ARG.004"]
return false, nil return false, nil
case *sqlparser.ColName:
// id in (1, 2, id), always true.
rule = HeuristicRules["ARG.014"]
return false, nil
} }
} }
if len(r) > common.Config.MaxInCount { if len(r) > common.Config.MaxInCount {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册