From fd3169dad7d4498a411ecf680d69bd2873332fc3 Mon Sep 17 00:00:00 2001
From: PuQing <me@puqing.work>
Date: Wed, 14 Dec 2022 15:17:01 +0800
Subject: [PATCH] [CodeStyle] fix c++17-extensions warning on macos (#49017)

* fix c++17-extensions warning on macos

* fix type

fix c++17-extensions warning on macos

fix c++17-extensions warning on macos
---
 cmake/flags.cmake                                       | 3 ++-
 paddle/phi/kernels/cpu/viterbi_decode_kernel.cc         | 4 ++--
 paddle/phi/kernels/strings/strings_lower_upper_kernel.h | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/cmake/flags.cmake b/cmake/flags.cmake
index 6e18249b1a..724d8185ec 100644
--- a/cmake/flags.cmake
+++ b/cmake/flags.cmake
@@ -220,7 +220,8 @@ if(APPLE)
       -Werror=uninitialized
       -Werror=tautological-constant-out-of-range-compare
       -Werror=literal-conversion
-      -Werror=pragma-pack)
+      -Werror=pragma-pack
+      -Werror=c++17-extensions)
 endif()
 
 if(WITH_HETERPS AND WITH_PSLIB)
diff --git a/paddle/phi/kernels/cpu/viterbi_decode_kernel.cc b/paddle/phi/kernels/cpu/viterbi_decode_kernel.cc
index ae6bb5ae4f..c520963b17 100644
--- a/paddle/phi/kernels/cpu/viterbi_decode_kernel.cc
+++ b/paddle/phi/kernels/cpu/viterbi_decode_kernel.cc
@@ -110,7 +110,7 @@ struct Gather {
 
 template <typename Context,
           template <typename InT, typename OutT>
-          typename CompareFunctor,
+          class CompareFunctor,
           typename T>
 struct GetMask {
   void operator()(const Context& dev_ctx,
@@ -124,7 +124,7 @@ struct GetMask {
 
 template <typename Context,
           template <typename T>
-          typename BinaryFunctor,
+          class BinaryFunctor,
           typename T>
 struct BinaryOperation {
   void operator()(const Context& dev_ctx,
diff --git a/paddle/phi/kernels/strings/strings_lower_upper_kernel.h b/paddle/phi/kernels/strings/strings_lower_upper_kernel.h
index 36486bc3ec..223ae4d938 100644
--- a/paddle/phi/kernels/strings/strings_lower_upper_kernel.h
+++ b/paddle/phi/kernels/strings/strings_lower_upper_kernel.h
@@ -94,7 +94,7 @@ struct AsciiCaseConverter {
 
 template <typename DeviceContext,
           template <typename DeviceContextT>
-          typename CharConverter>
+          class CharConverter>
 struct UTF8CaseConverter {
   void operator()(const DeviceContext& dev_ctx,
                   const pstring* in,
-- 
GitLab