Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
wmsofts
Paddle
提交
13e4756f
P
Paddle
项目概览
wmsofts
/
Paddle
与 Fork 源项目一致
Fork自
PaddlePaddle / Paddle
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
P
Paddle
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
13e4756f
编写于
12月 23, 2019
作者:
Z
zhouwei25
提交者:
Tao Luo
12月 23, 2019
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
change ci check rule of deleting unit-test (#21876)
上级
c63ce411
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
19 addition
and
5 deletion
+19
-5
paddle/scripts/paddle_build.sh
paddle/scripts/paddle_build.sh
+17
-3
tools/diff_unittest.py
tools/diff_unittest.py
+2
-2
未找到文件。
paddle/scripts/paddle_build.sh
浏览文件 @
13e4756f
...
...
@@ -411,6 +411,7 @@ function run_mac_test() {
========================================
EOF
#remove proxy here to fix dist error on mac
my_proxy
=
$http_proxy
export
http_proxy
=
export
https_proxy
=
# make install should also be test when unittest
...
...
@@ -442,6 +443,9 @@ EOF
ctest
--output-on-failure
-j
$2
paddle version
# Recovery proxy to avoid failure in later steps
export
http_proxy
=
$my_proxy
export
https_proxy
=
$my_proxy
fi
}
...
...
@@ -513,6 +517,10 @@ function generate_api_spec() {
}
function
check_approvals_of_unittest
()
{
set
+x
if
[
"
$GITHUB_API_TOKEN
"
==
""
]
||
[
"
$GIT_PR_ID
"
==
""
]
;
then
return
0
fi
# approval_user_list: XiaoguangHu01 46782768,luotao1 6836917,phlrain 43953930,lanxianghit 47554610, zhouwei25 52485244, kolinwei 22165420
approval_line
=
`
curl
-H
"Authorization: token
${
GITHUB_API_TOKEN
}
"
https://api.github.com/repos/PaddlePaddle/Paddle/pulls/
${
GIT_PR_ID
}
/reviews?per_page
=
10000
`
check_times
=
$1
...
...
@@ -526,7 +534,9 @@ function check_approvals_of_unittest() {
exit
0
fi
elif
[
$1
==
2
]
;
then
set
-x
unittest_spec_diff
=
`
python
${
PADDLE_ROOT
}
/tools/diff_unittest.py
${
PADDLE_ROOT
}
/paddle/fluid/UNITTEST_DEV.spec
${
PADDLE_ROOT
}
/paddle/fluid/UNITTEST_PR.spec
`
set
+x
if
[
"
$unittest_spec_diff
"
!=
""
]
;
then
APPROVALS
=
`
echo
${
approval_line
}
|python
${
PADDLE_ROOT
}
/tools/check_pr_approval.py 1 22165420 52485244 6836917
`
echo
"current pr
${
GIT_PR_ID
}
got approvals:
${
APPROVALS
}
"
...
...
@@ -542,18 +552,16 @@ function check_approvals_of_unittest() {
fi
fi
fi
set
-x
}
function
check_change_of_unittest
()
{
set
+x
generate_unittest_spec
"PR"
fetch_upstream_develop_if_not_exist
git fetch upstream
git reset
--hard
upstream/
$BRANCH
cmake_gen
$1
generate_unittest_spec
"DEV"
check_approvals_of_unittest 2
set
+x
}
function
generate_unittest_spec
()
{
...
...
@@ -1152,6 +1160,12 @@ function main() {
check_style
;;
cicheck
)
cmake_gen
${
PYTHON_ABI
:-
""
}
build
${
parallel_number
}
enable_unused_var_check
parallel_test
;;
cicheck_coverage
)
check_approvals_of_unittest 1
cmake_gen
${
PYTHON_ABI
:-
""
}
build
${
parallel_number
}
...
...
tools/diff_unittest.py
浏览文件 @
13e4756f
...
...
@@ -18,12 +18,12 @@ diffs = []
for
each_diff
in
result
:
if
each_diff
[
0
]
==
'-'
:
# delete unit test is not allowed
error
=
True
diffs
.
append
(
each_diff
[
2
]
)
diffs
.
append
(
each_diff
)
'''
If you delete the unit test, such as commenting it out,
please ask for approval of one RD below for passing CI:
-
XiaoguangHu01 or luotao1 or phlrain or lanxianghit or zhouwei25
-
kolinwei(recommended) or zhouwei25 or luotao1
'''
if
error
:
for
each_diff
in
diffs
:
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录