From 6f70e27011d1f1aae222b735cdf6dc1380b062a9 Mon Sep 17 00:00:00 2001
From: Dirk Mueller <dmueller@suse.com>
Date: Wed, 2 Oct 2019 13:29:24 +0200
Subject: [PATCH] Base64::encode : const correctness / String by reference
 passing (#3314)

Avoid passing String by-value, which is slightly less efficient
as it involves a full copy-constructor/tempstring creation.
---
 cores/esp32/base64.cpp | 8 ++++----
 cores/esp32/base64.h   | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/cores/esp32/base64.cpp b/cores/esp32/base64.cpp
index e7ba3fadb..1fc144e26 100644
--- a/cores/esp32/base64.cpp
+++ b/cores/esp32/base64.cpp
@@ -31,11 +31,11 @@ extern "C" {
 
 /**
  * convert input data to base64
- * @param data uint8_t *
+ * @param data const uint8_t *
  * @param length size_t
  * @return String
  */
-String base64::encode(uint8_t * data, size_t length)
+String base64::encode(const uint8_t * data, size_t length)
 {
     size_t size = base64_encode_expected_len(length) + 1;
     char * buffer = (char *) malloc(size);
@@ -54,10 +54,10 @@ String base64::encode(uint8_t * data, size_t length)
 
 /**
  * convert input data to base64
- * @param text String
+ * @param text const String&
  * @return String
  */
-String base64::encode(String text)
+String base64::encode(const String& text)
 {
     return base64::encode((uint8_t *) text.c_str(), text.length());
 }
diff --git a/cores/esp32/base64.h b/cores/esp32/base64.h
index 8e6726a35..97095817b 100644
--- a/cores/esp32/base64.h
+++ b/cores/esp32/base64.h
@@ -4,8 +4,8 @@
 class base64
 {
 public:
-    static String encode(uint8_t * data, size_t length);
-    static String encode(String text);
+    static String encode(const uint8_t * data, size_t length);
+    static String encode(const String& text);
 private:
 };
 
-- 
GitLab