From ba9646ed567c6625607d3e1fdb31075689254284 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lucas=20K=C3=A4ldstr=C3=B6m?=
 <lucas.kaldstrom@hotmail.co.uk>
Date: Tue, 10 May 2016 21:06:06 +0300
Subject: [PATCH] Added error handling for certs as commented

---
 cmd/localkube/cmd/start.go         |  6 +++++-
 pkg/localkube/kube2sky/kube2sky.go |  1 -
 pkg/localkube/localkube.go         | 10 +++++++---
 3 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/cmd/localkube/cmd/start.go b/cmd/localkube/cmd/start.go
index cf98181f5..fd7e16bea 100644
--- a/cmd/localkube/cmd/start.go
+++ b/cmd/localkube/cmd/start.go
@@ -56,7 +56,11 @@ func init() {
 
 func SetupServer(s *localkube.LocalkubeServer) {
 
-	s.GenerateCerts()
+	err := s.GenerateCerts()
+	if err != nil {
+		fmt.Println("Failed to create certificates!")
+		panic(err)
+	}
 
 	// setup etcd
 	etcd, err := s.NewEtcd(localkube.KubeEtcdClientURLs, localkube.KubeEtcdPeerURLs, "kubeetcd", s.GetEtcdDataDirectory())
diff --git a/pkg/localkube/kube2sky/kube2sky.go b/pkg/localkube/kube2sky/kube2sky.go
index 75777b27e..5248081e7 100644
--- a/pkg/localkube/kube2sky/kube2sky.go
+++ b/pkg/localkube/kube2sky/kube2sky.go
@@ -36,7 +36,6 @@ import (
 	etcd "github.com/coreos/go-etcd/etcd"
 	"github.com/golang/glog"
 	skymsg "github.com/skynetservices/skydns/msg"
-	//flag "github.com/spf13/pflag"
 	kapi "k8s.io/kubernetes/pkg/api"
 	"k8s.io/kubernetes/pkg/api/endpoints"
 	"k8s.io/kubernetes/pkg/api/unversioned"
diff --git a/pkg/localkube/localkube.go b/pkg/localkube/localkube.go
index 105f686d3..06bd9032c 100644
--- a/pkg/localkube/localkube.go
+++ b/pkg/localkube/localkube.go
@@ -82,11 +82,11 @@ func (lk LocalkubeServer) GetHostIP() (net.IP, error) {
 	return utilnet.ChooseBindAddress(net.ParseIP("0.0.0.0"))
 }
 
-func (lk LocalkubeServer) GenerateCerts() {
+func (lk LocalkubeServer) GenerateCerts() error {
 
 	if util.CanReadFile(lk.GetPublicKeyCertPath()) && util.CanReadFile(lk.GetPrivateKeyCertPath()) {
-		fmt.Println("Using existing certs")
-		return
+		fmt.Println("Using these existing certs: ", lk.GetPublicKeyCertPath(), lk.GetPrivateKeyCertPath())
+		return nil
 	}
 
 	alternateIPs := []net.IP{lk.ServiceClusterIPRange.IP}
@@ -94,9 +94,13 @@ func (lk LocalkubeServer) GenerateCerts() {
 	hostIP, err := lk.GetHostIP()
 	if err != nil {
 		fmt.Println("Failed to get host IP: ", err)
+		return err
 	}
 
 	if err := utilcrypto.GenerateSelfSignedCert(hostIP.String(), lk.GetPublicKeyCertPath(), lk.GetPrivateKeyCertPath(), alternateIPs, alternateDNS); err != nil {
 		fmt.Println("Failed to create certs: ", err)
+		return err
 	}
+
+	return nil
 }
-- 
GitLab