Merge pull request #9856 from priyawadhwa/dont-fail

metrics script: don't fail if one container runtime fails

hack/metrics/metrics.go

@@ -82,7 +82,15 @@ func execute() error {
 		return errors.Wrap(err, "registering view")
 	}
 	for _, cr := range []string{"docker", "containerd", "crio"} {
-		sd, err := getExporter(projectID, cr)
+		if err := exportMinikubeStart(ctx, projectID, cr); err != nil {
+			log.Printf("error exporting minikube start data for runtime %v: %v", cr, err)
+		}
+	}
+	return nil
+}
+
+func exportMinikubeStart(ctx context.Context, projectID, containerRuntime string) error {
+	sd, err := getExporter(projectID, containerRuntime)
 	if err != nil {
 		return errors.Wrap(err, "getting stackdriver exporter")
 	}
@@ -93,7 +101,7 @@ func execute() error {
 		return errors.Wrap(err, "starting metric exporter")
 	}
 	// track minikube start time and record it to metrics collector
-		st, err := minikubeStartTime(ctx, projectID, tmpFile, cr)
+	st, err := minikubeStartTime(ctx, projectID, tmpFile, containerRuntime)
 	if err != nil {
 		return errors.Wrap(err, "collecting start time")
 	}
@@ -103,7 +111,6 @@ func execute() error {
 	sd.Flush()
 	sd.StopMetricsExporter()
 	trace.UnregisterExporter(sd)
-	}
 	return nil
 }