From 645c7ee0bef6483baa26566e9e4676f51645dccb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Str=C3=B6mberg?= Date: Tue, 21 May 2019 17:26:03 -0700 Subject: [PATCH] Improve tagging instructions --- docs/contributors/releasing_minikube.md | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/docs/contributors/releasing_minikube.md b/docs/contributors/releasing_minikube.md index 9cf9b1fa0..0dddb097a 100644 --- a/docs/contributors/releasing_minikube.md +++ b/docs/contributors/releasing_minikube.md @@ -54,12 +54,8 @@ Merge the output into CHANGELOG.md. See [PR#3175](https://github.com/kubernetes/ ## Tag the Release -NOTE: Confirm that all release-related PR's have been submitted before doing this step. - -Do this in a direct clone of the upstream kubernetes/minikube repository (not your fork!): - ```shell -hack/tag_release.sh +sh hack/tag_release.sh 1.. ``` ## Build the Release @@ -75,7 +71,7 @@ This step uses the git tag to publish new binaries to GCS and create a github re ## Check the release logs -Once the release completes, click "Console Output" to look or anything unusual. This is typically where you will see the brew automation fail, for instance. +After job completion, click "Console Output" to verify that the release completed without errors. This is typically where one will see brew automation fail, for instance. ## Check releases.json -- GitLab