Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
weixin_43355755
engine
提交
e50bfbe9
E
engine
项目概览
weixin_43355755
/
engine
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
E
engine
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
e50bfbe9
编写于
9月 06, 2019
作者:
F
Ferhat
提交者:
GitHub
9月 06, 2019
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix multi span text ruler cache lookup failure. (#12023)
上级
b9ce2500
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
40 addition
and
1 deletion
+40
-1
lib/web_ui/lib/src/engine/text/ruler.dart
lib/web_ui/lib/src/engine/text/ruler.dart
+6
-1
lib/web_ui/test/paragraph_test.dart
lib/web_ui/test/paragraph_test.dart
+34
-0
未找到文件。
lib/web_ui/lib/src/engine/text/ruler.dart
浏览文件 @
e50bfbe9
...
...
@@ -759,8 +759,13 @@ class ParagraphRuler {
MeasurementResult
cacheLookup
(
EngineParagraph
paragraph
,
ui
.
ParagraphConstraints
constraints
)
{
final
String
plainText
=
paragraph
.
_plainText
;
if
(
plainText
==
null
)
{
// Multi span paragraph, do not use cache item.
return
null
;
}
final
List
<
MeasurementResult
>
constraintCache
=
_measurementCache
[
paragraph
.
_
plainText
];
_measurementCache
[
plainText
];
if
(
constraintCache
==
null
)
{
return
null
;
}
...
...
lib/web_ui/test/paragraph_test.dart
浏览文件 @
e50bfbe9
...
...
@@ -62,4 +62,38 @@ void main() async {
);
}
});
// Regression test for https://github.com/flutter/flutter/issues/37744
test
(
'measures heights of multiple multi-span paragraphs'
,
()
{
const
double
fontSize
=
20.0
;
final
ParagraphBuilder
builder
=
ParagraphBuilder
(
ParagraphStyle
(
fontFamily:
'Ahem'
,
fontStyle:
FontStyle
.
normal
,
fontWeight:
FontWeight
.
normal
,
fontSize:
fontSize
,
));
builder
.
addText
(
'1234567890 1234567890 1234567890 1234567890 1234567890'
);
builder
.
addText
(
'1234567890 1234567890 1234567890 1234567890 1234567890'
);
builder
.
pushStyle
(
TextStyle
(
fontWeight:
FontWeight
.
bold
));
builder
.
addText
(
'span0'
);
final
Paragraph
paragraph
=
builder
.
build
();
paragraph
.
layout
(
ParagraphConstraints
(
width:
fontSize
*
5.0
));
expect
(
paragraph
.
height
,
closeTo
(
fontSize
*
3.0
,
0.001
));
// because it wraps
// Now create another builder with just a single line of text so
// it tries to reuse ruler cache but misses.
final
ParagraphBuilder
builder2
=
ParagraphBuilder
(
ParagraphStyle
(
fontFamily:
'Ahem'
,
fontStyle:
FontStyle
.
normal
,
fontWeight:
FontWeight
.
normal
,
fontSize:
fontSize
,
));
builder2
.
addText
(
'span1'
);
builder2
.
pushStyle
(
TextStyle
(
fontWeight:
FontWeight
.
bold
));
builder2
.
addText
(
'span2'
);
final
Paragraph
paragraph2
=
builder2
.
build
();
paragraph2
.
layout
(
ParagraphConstraints
(
width:
fontSize
*
5.0
));
expect
(
paragraph2
.
height
,
closeTo
(
fontSize
,
0.001
));
// because it wraps
});
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录