From c5c3f31a171416c66d463e882b6cb79fd315c1b0 Mon Sep 17 00:00:00 2001 From: Adam Barth Date: Thu, 4 Jun 2015 15:50:07 -0700 Subject: [PATCH] Make the StockList actually work in stocks2 RenderScaffold needs to attach and detach its children when asked. R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1149893025 --- examples/stocks2/lib/stock_app.dart | 2 +- sdk/lib/framework/components2/scaffold.dart | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/examples/stocks2/lib/stock_app.dart b/examples/stocks2/lib/stock_app.dart index 967a25674b..baf7b91719 100644 --- a/examples/stocks2/lib/stock_app.dart +++ b/examples/stocks2/lib/stock_app.dart @@ -204,7 +204,7 @@ class StocksApp extends App { List overlays = [ new Scaffold( toolbar: _isSearching ? buildSearchBar() : buildToolBar(), - // body: new Stocklist(stocks: _stocks, query: _searchQuery), + body: new Stocklist(stocks: _stocks, query: _searchQuery), // floatingActionButton: new FloatingActionButton( // content: new Icon(type: 'content/add_white', size: 24), // level: 3), diff --git a/sdk/lib/framework/components2/scaffold.dart b/sdk/lib/framework/components2/scaffold.dart index 37ca9d3a6d..fc58d2d5f2 100644 --- a/sdk/lib/framework/components2/scaffold.dart +++ b/sdk/lib/framework/components2/scaffold.dart @@ -46,6 +46,22 @@ class RenderScaffold extends RenderBox { markNeedsLayout(); } + void attachChildren() { + for (ScaffoldSlots slot in ScaffoldSlots.values) { + RenderBox box = _slots[slot]; + if (box != null) + box.attach(); + } + } + + void detachChildren() { + for (ScaffoldSlots slot in ScaffoldSlots.values) { + RenderBox box = _slots[slot]; + if (box != null) + box.detach(); + } + } + ScaffoldSlots remove(RenderBox child) { assert(child != null); for (ScaffoldSlots slot in ScaffoldSlots.values) { -- GitLab