From af618ee718f479ee53a308a455214cde10690167 Mon Sep 17 00:00:00 2001 From: Jim Graham Date: Mon, 13 Sep 2021 17:37:02 -0700 Subject: [PATCH] prepare drawPoints MaskFilter test for Skia bug fix (#28596) --- flow/display_list_canvas_unittests.cc | 32 ++++++++++++++++++++------- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/flow/display_list_canvas_unittests.cc b/flow/display_list_canvas_unittests.cc index 24b130cb86..24e821ef1a 100644 --- a/flow/display_list_canvas_unittests.cc +++ b/flow/display_list_canvas_unittests.cc @@ -334,17 +334,33 @@ class CanvasCompareTester { sk_sp filter = SkMaskFilter::MakeBlur(kNormal_SkBlurStyle, 5.0); { - RenderWith([=](SkCanvas*, SkPaint& p) { p.setMaskFilter(filter); }, - [=](DisplayListBuilder& b) { b.setMaskFilter(filter); }, - cv_renderer, dl_renderer, "MaskFilter == Blur 5"); + RenderWith( + [=](SkCanvas*, SkPaint& p) { + // Provide some non-trivial stroke size to get blurred + p.setStrokeWidth(3.0); + p.setMaskFilter(filter); + }, + [=](DisplayListBuilder& b) { + // Provide some non-trivial stroke size to get blurred + b.setStrokeWidth(3.0); + b.setMaskFilter(filter); + }, + cv_renderer, dl_renderer, "MaskFilter == Blur 5"); } ASSERT_TRUE(filter->unique()) << "MaskFilter Cleanup"; { - RenderWith([=](SkCanvas*, SkPaint& p) { p.setMaskFilter(filter); }, - [=](DisplayListBuilder& b) { - b.setMaskBlurFilter(kNormal_SkBlurStyle, 5.0); - }, - cv_renderer, dl_renderer, "MaskFilter == Blur(Normal, 5.0)"); + RenderWith( + [=](SkCanvas*, SkPaint& p) { + // Provide some non-trivial stroke size to get blurred + p.setStrokeWidth(3.0); + p.setMaskFilter(filter); + }, + [=](DisplayListBuilder& b) { + // Provide some non-trivial stroke size to get blurred + b.setStrokeWidth(3.0); + b.setMaskBlurFilter(kNormal_SkBlurStyle, 5.0); + }, + cv_renderer, dl_renderer, "MaskFilter == Blur(Normal, 5.0)"); } ASSERT_TRUE(filter->unique()) << "MaskFilter Cleanup"; } -- GitLab