diff --git a/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java b/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java index 078d34b10b02a84837ad6bb0b34dd884833cab9c..a22b0b25a7a1cf5699185c0bb9ca5b1a83e783ea 100644 --- a/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java +++ b/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java @@ -251,12 +251,6 @@ public class PlainPermissionManager { } public boolean updateGlobalWhiteAddrsConfig(List globalWhiteAddrsList) { - - if (globalWhiteAddrsList == null) { - log.error("Parameter value globalWhiteAddrsList is null,Please check your parameter"); - return false; - } - Map aclAccessConfigMap = AclUtils.getYamlDataObject(fileHome + File.separator + fileName, Map.class); if (aclAccessConfigMap == null || aclAccessConfigMap.isEmpty()) { @@ -266,9 +260,10 @@ public class PlainPermissionManager { if (globalWhiteRemoteAddrList != null) { globalWhiteRemoteAddrList.clear(); - globalWhiteRemoteAddrList.addAll(globalWhiteAddrsList); - - // Update globalWhiteRemoteAddr element in memeory map firstly + if (globalWhiteAddrsList != null) { + globalWhiteRemoteAddrList.addAll(globalWhiteAddrsList); + } + // Update globalWhiteRemoteAddr element in memory map firstly aclAccessConfigMap.put(AclConstants.CONFIG_GLOBAL_WHITE_ADDRS, globalWhiteRemoteAddrList); if (AclUtils.writeDataObject(fileHome + File.separator + fileName, updateAclConfigFileVersion(aclAccessConfigMap))) { return true;