From 4ca922bbb56c6ea4ff0f0d74d0fc54cbe3a3307a Mon Sep 17 00:00:00 2001 From: Chen Weihang Date: Wed, 20 May 2020 17:54:36 +0800 Subject: [PATCH] Fix boost get ci rule (#24656) --- tools/check_api_approvals.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/check_api_approvals.sh b/tools/check_api_approvals.sh index c5db1499887..e6d41c11ce1 100644 --- a/tools/check_api_approvals.sh +++ b/tools/check_api_approvals.sh @@ -157,7 +157,7 @@ if [ ${HAS_CONST_CAST} ] && [ "${GIT_PR_ID}" != "" ]; then fi HAS_BOOST_GET=`git diff -U0 upstream/$BRANCH |grep "^+" |grep -o -m 1 "boost::get" || true` -if [ ${HAS_CONST_CAST} ] && [ "${GIT_PR_ID}" != "" ]; then +if [ ${HAS_BOOST_GET} ] && [ "${GIT_PR_ID}" != "" ]; then echo_line="boost::get is not recommended, because it may throw an bad_get exception without any stack information, so please use BOOST_GET(_**)(dtype, value) series macros here. If these macros cannot meet your needs, please use try-catch to handle boost::get and specify chenwhql (Recommend), luotao1 or lanxianghit review and approve.\n" check_approval 1 6836917 47554610 22561442 fi -- GitLab